Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sub aggregations on filter rewrite optimization #15253

Closed

Conversation

finnegancarroll
Copy link
Contributor

Description

Follow up on filter rewrite optimization work. See: #13317, #13865, #14464.
The filter rewrite optimization path for aggregations is currently disabled when a sub aggregation is present. In this case we default back to the iterative doc values approach of collecting docs into our aggregation buckets.

This change adds support for sub aggregations by collecting doc ids into our sub aggregation while traversing the PointValues.PointTree. While we are still considering each doc id, we expect a modest performance boost using the PointValues.PointTree.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]
#12602

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 701ed58: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for d05b2e3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant