Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snapshot V2] Support pinned timestamp in delete flow #15256

Merged

Conversation

anshu1106
Copy link
Contributor

@anshu1106 anshu1106 commented Aug 15, 2024

Description

This PR introduce changes to support pinned timestamp in delete flow

  • With pinned timestamp we don't create explicit lock files and we can avoid the logic to query and delete lock files
  • Unpin timestamp for deleted snapshots
  • support deletion of remote store segment files for deleted indices

Related Issues

Resolves #15255
#15466

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Anshu Agarwal added 10 commits August 6, 2024 10:43
Signed-off-by: Anshu Agarwal <[email protected]>
Signed-off-by: Anshu Agarwal <[email protected]>
Signed-off-by: Anshu Agarwal <[email protected]>
Signed-off-by: Anshu Agarwal <[email protected]>
Signed-off-by: Anshu Agarwal <[email protected]>
Signed-off-by: Anshu Agarwal <[email protected]>
Signed-off-by: Anshu Agarwal <[email protected]>
Signed-off-by: Anshu Agarwal <[email protected]>
@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Storage:Snapshots labels Aug 15, 2024
Copy link
Contributor

❌ Gradle check result for afcc37a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for c91f1b5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Anshu Agarwal added 4 commits August 21, 2024 11:13
@anshu1106 anshu1106 marked this pull request as ready for review August 22, 2024 09:11
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15256-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5bf34d21d8345befbe02181c9b6fd28dd360eb2b
# Push it to GitHub
git push --set-upstream origin backport/backport-15256-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15256-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.17
# Create a new branch
git switch --create backport/backport-15256-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5bf34d21d8345befbe02181c9b6fd28dd360eb2b
# Push it to GitHub
git push --set-upstream origin backport/backport-15256-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-15256-to-2.17.

mch2 added a commit to mch2/OpenSearch that referenced this pull request Sep 4, 2024
mch2 added a commit to mch2/OpenSearch that referenced this pull request Sep 4, 2024
anshu1106 added a commit to anshu1106/OpenSearch that referenced this pull request Sep 5, 2024
gbbafna pushed a commit that referenced this pull request Sep 5, 2024
anshu1106 added a commit to anshu1106/OpenSearch that referenced this pull request Sep 5, 2024
anshu1106 added a commit to anshu1106/OpenSearch that referenced this pull request Sep 5, 2024
…ject#15256)

Signed-off-by: Anshu Agarwal <[email protected]>
(cherry picked from commit 5bf34d2)
Signed-off-by: Anshu Agarwal <[email protected]>
sachinpkale pushed a commit that referenced this pull request Sep 5, 2024
(cherry picked from commit 5bf34d2)

Signed-off-by: Anshu Agarwal <[email protected]>
Co-authored-by: Anshu Agarwal <[email protected]>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport 2.17 backport-failed enhancement Enhancement or improvement to existing feature or request skip-changelog Storage:Snapshots
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Snapshot V2] Integrate delete snapshot flow with pinned timestamp
3 participants