Update minimumCompilerVersion to use jdk 11 #15307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
reta
reviewed
Aug 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1.3 #15307 +/- ##
============================================
- Coverage 77.56% 77.50% -0.07%
+ Complexity 58760 58748 -12
============================================
Files 4223 4223
Lines 253441 253445 +4
Branches 38701 38701
============================================
- Hits 196590 196433 -157
- Misses 40844 40998 +154
- Partials 16007 16014 +7 ☔ View full report in Codecov by Sentry. |
reta
reviewed
Aug 19, 2024
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
force-pushed
the
mincompilejdk-fix
branch
from
01e5418
to
16b3c3b
Compare
reta
changed the title
reta
approved these changes
Aug 19, 2024
|
❌ Gradle check result for 16b3c3b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
peterzhuamazon
merged commit 3ce0904
into
opensearch-project:1.3
20 of 21 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
* Update minimumCompilerVersion to use jdk 8 Signed-off-by: Peter Zhu <[email protected]> * Update to 11 Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit 3ce0904) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Aug 19, 2024
* Update minimumCompilerVersion to use jdk 8 * Update to 11 --------- (cherry picked from commit 3ce0904) Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update minimumCompilerVersion to use jdk 11
Based on the documentation update here: opensearch-project/documentation-website#7861
Related Issues
opensearch-project/opensearch-build#4952
Check List
[ ] Functionality includes testing.[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.