Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Star tree mapping changes #15320

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

bharath-techie
Copy link
Contributor

@bharath-techie bharath-techie commented Aug 20, 2024

Description

Backport of #14605 - Star tree mapper changes

Have added new constructors for BWC breaking changes - 6b4a4ff

Related Issues

Resolves #14386

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Star tree mapping changes with feature flag
---------
Signed-off-by: Bharathwaj G <[email protected]>
Copy link
Contributor

✅ Gradle check result for d890e08: SUCCESS

Copy link
Contributor

❕ Gradle check result for 3b4cdcd: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

✅ Gradle check result for 6b4a4ff: SUCCESS

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 74.71042% with 131 lines in your changes missing coverage. Please review.

Project coverage is 71.57%. Comparing base (3971a25) to head (e7a3396).
Report is 2 commits behind head on 2.x.

Files Patch % Lines
...va/org/opensearch/index/mapper/StarTreeMapper.java 81.81% 20 Missing and 8 partials ⚠️
...java/org/opensearch/index/mapper/ObjectMapper.java 56.60% 14 Missing and 9 partials ⚠️
...siteindex/datacube/startree/StarTreeValidator.java 65.78% 9 Missing and 4 partials ⚠️
...ndex/compositeindex/datacube/DimensionFactory.java 58.62% 8 Missing and 4 partials ⚠️
.../datacube/startree/StarTreeFieldConfiguration.java 72.72% 6 Missing and 3 partials ⚠️
...ompositeindex/datacube/startree/StarTreeField.java 80.00% 2 Missing and 5 partials ⚠️
...nsearch/index/mapper/CompositeMappedFieldType.java 64.70% 6 Missing ⚠️
...h/index/compositeindex/CompositeIndexSettings.java 58.33% 4 Missing and 1 partial ⚠️
.../index/compositeindex/CompositeIndexValidator.java 50.00% 3 Missing and 1 partial ⚠️
...ensearch/index/compositeindex/datacube/Metric.java 80.00% 1 Missing and 3 partials ⚠️
... and 10 more
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15320      +/-   ##
============================================
+ Coverage     71.53%   71.57%   +0.04%     
- Complexity    62954    63060     +106     
============================================
  Files          5158     5172      +14     
  Lines        295467   295983     +516     
  Branches      43032    43114      +82     
============================================
+ Hits         211367   211859     +492     
+ Misses        66378    66351      -27     
- Partials      17722    17773      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale
Copy link
Member

Please mention conflicts occurred (if any) while creating the manual backport.

Copy link
Contributor

✅ Gradle check result for e7a3396: SUCCESS

@sachinpkale sachinpkale merged commit 7745cdb into opensearch-project:2.x Aug 22, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants