Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unchecked cast in dynamic action map getter #15394

Merged
merged 2 commits into from
Aug 24, 2024

Conversation

dbwiddis
Copy link
Member

Description

Fixes an unchecked cast in dynamic action map getter

Related Issues

Resolves #15388

Check List

  • Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock
Copy link
Member

dblock commented Aug 24, 2024

Rebase?

Copy link
Contributor

✅ Gradle check result for 8d91255: SUCCESS

Copy link

codecov bot commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.83%. Comparing base (0eb63bd) to head (48d55e8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15394      +/-   ##
============================================
- Coverage     71.90%   71.83%   -0.07%     
+ Complexity    63244    63172      -72     
============================================
  Files          5224     5224              
  Lines        296077   296079       +2     
  Branches      42762    42763       +1     
============================================
- Hits         212884   212701     -183     
- Misses        65661    65941     +280     
+ Partials      17532    17437      -95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis
Copy link
Member Author

Rebase?

Of course. I suspect the vast majority of failed backports and rebases are due to always appending to the end of the same changelog. :|

Copy link
Contributor

✅ Gradle check result for 48d55e8: SUCCESS

@dblock dblock merged commit 6152afe into opensearch-project:main Aug 24, 2024
34 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15394-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6152afeef3ceb3fe4f18f6be2d55ac60256bc2db
# Push it to GitHub
git push --set-upstream origin backport/backport-15394-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15394-to-2.x.

dbwiddis added a commit to dbwiddis/OpenSearch that referenced this pull request Aug 24, 2024
dblock pushed a commit that referenced this pull request Aug 25, 2024
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed bug Something isn't working extensions Other
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Suspicious usage of Map in ActionModule line 1205
2 participants