-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unchecked cast in dynamic action map getter #15394
Conversation
Signed-off-by: Daniel Widdis <[email protected]>
Rebase? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15394 +/- ##
============================================
- Coverage 71.90% 71.83% -0.07%
+ Complexity 63244 63172 -72
============================================
Files 5224 5224
Lines 296077 296079 +2
Branches 42762 42763 +1
============================================
- Hits 212884 212701 -183
- Misses 65661 65941 +280
+ Partials 17532 17437 -95 ☔ View full report in Codecov by Sentry. |
Of course. I suspect the vast majority of failed backports and rebases are due to always appending to the end of the same changelog. :| |
Signed-off-by: Daniel Widdis <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15394-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6152afeef3ceb3fe4f18f6be2d55ac60256bc2db
# Push it to GitHub
git push --set-upstream origin backport/backport-15394-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…5394) Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
…5394) Signed-off-by: Daniel Widdis <[email protected]>
…5394) Signed-off-by: Daniel Widdis <[email protected]>
…5394) Signed-off-by: Daniel Widdis <[email protected]>
…5394) Signed-off-by: Daniel Widdis <[email protected]>
Description
Fixes an unchecked cast in dynamic action map getter
Related Issues
Resolves #15388
Check List
[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.