Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Changes to build star tree in off heap #15398

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a918530 from #14817.

---------

Signed-off-by: Bharathwaj G <[email protected]>
(cherry picked from commit a918530)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❕ Gradle check result for 77e886a: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 82.51599% with 82 lines in your changes missing coverage. Please review.

Project coverage is 71.59%. Comparing base (4f97fd3) to head (77e886a).
Report is 4 commits behind head on 2.x.

Files Patch % Lines
...acube/startree/builder/OffHeapStarTreeBuilder.java 78.41% 27 Missing and 3 partials ⚠️
...startree/builder/AbstractDocumentsFileManager.java 74.69% 16 Missing and 5 partials ⚠️
...cube/startree/builder/StarTreeDocsFileManager.java 89.25% 5 Missing and 8 partials ⚠️
.../opensearch/common/util/ByteArrayBackedBitset.java 75.00% 7 Missing ⚠️
...tacube/startree/utils/StarTreeDocumentsSorter.java 86.36% 2 Missing and 1 partial ⚠️
...acube/startree/builder/SegmentDocsFileManager.java 93.75% 2 Missing ⚠️
...ex/datacube/startree/builder/StarTreesBuilder.java 50.00% 2 Missing ⚠️
...ex/codec/composite/Composite99DocValuesWriter.java 50.00% 0 Missing and 1 partial ⚠️
...datacube/startree/builder/BaseStarTreeBuilder.java 95.23% 0 Missing and 1 partial ⚠️
...ube/startree/utils/StarTreeDocumentBitSetUtil.java 91.66% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15398      +/-   ##
============================================
+ Coverage     71.52%   71.59%   +0.07%     
- Complexity    63228    63398     +170     
============================================
  Files          5197     5204       +7     
  Lines        296727   297289     +562     
  Branches      43179    43269      +90     
============================================
+ Hits         212221   212850     +629     
+ Misses        66696    66584     -112     
- Partials      17810    17855      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock dblock merged commit 4c4d4d7 into 2.x Aug 24, 2024
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant