Schedule reroute after allocator timed out #15565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishab Nahata <[email protected]>
Bukhtawar
reviewed
Sep 2, 2024
|
❌ Gradle check result for 7cf09a5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Rishab Nahata <[email protected]>
Signed-off-by: Rishab Nahata <[email protected]>
|
❌ Gradle check result for d09b40d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for a8717d9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Rishab Nahata <[email protected]>
|
❌ Gradle check result for edc02b0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
imRishN
requested review from
anasalkouz,
andrross,
ashking94,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize and
owaiskazi19
as code owners
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
* Schedule reroute after allocator timed out Signed-off-by: Rishab Nahata <[email protected]> (cherry picked from commit 4f50b4d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
* Schedule reroute after allocator timed out Signed-off-by: Rishab Nahata <[email protected]> (cherry picked from commit 4f50b4d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross
pushed a commit
that referenced
this pull request
Sep 5, 2024
* Schedule reroute after allocator timed out (#15565) * Schedule reroute after allocator timed out Signed-off-by: Rishab Nahata <[email protected]> * Coverage fix Signed-off-by: Rishab Nahata <[email protected]> --------- Signed-off-by: Rishab Nahata <[email protected]>
Arpit-Bandejiya
pushed a commit
to Arpit-Bandejiya/OpenSearch
that referenced
this pull request
Sep 5, 2024
* Schedule reroute after allocator timed out Signed-off-by: Rishab Nahata <[email protected]> (cherry picked from commit 4f50b4d)
3 tasks
Arpit-Bandejiya
pushed a commit
to Arpit-Bandejiya/OpenSearch
that referenced
this pull request
Sep 5, 2024
* Schedule reroute after allocator timed out Signed-off-by: Rishab Nahata <[email protected]> (cherry picked from commit 4f50b4d)
ashking94
pushed a commit
that referenced
this pull request
Sep 5, 2024
* Schedule reroute after allocator timed out Signed-off-by: Rishab Nahata <[email protected]> (cherry picked from commit 4f50b4d) Co-authored-by: Rishab Nahata <[email protected]>
sumitasr
pushed a commit
to sumitasr/OpenSearch
that referenced
this pull request
Sep 6, 2024
…opensearch-project#15749) * Schedule reroute after allocator timed out Signed-off-by: Rishab Nahata <[email protected]> (cherry picked from commit 4f50b4d) Co-authored-by: Rishab Nahata <[email protected]>
This was referenced Sep 6, 2024
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
* Schedule reroute after allocator timed out Signed-off-by: Rishab Nahata <[email protected]>
This was referenced Sep 11, 2024
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
* Schedule reroute after allocator timed out Signed-off-by: Rishab Nahata <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
* Schedule reroute after allocator timed out Signed-off-by: Rishab Nahata <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
* Schedule reroute after allocator timed out Signed-off-by: Rishab Nahata <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to schedule a reroute whenever an allocator times out. This would ensure that we never let a shard in an unassigned state because the current reroute cycle timed out.
Related Issues
Resolves #14945
Check List
[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.