Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Support cancellation for admin apis (#13966) #15594

Merged

Conversation

aasom143
Copy link
Contributor

@aasom143 aasom143 commented Sep 3, 2024

  • Support cancellation for admin apis - add implementation for _cat/shards

Signed-off-by: Somesh Gupta [email protected]
(cherry picked from commit 9f81479)

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Support cancellation for admin apis - add implementation for _cat/shards

Signed-off-by: Somesh Gupta <[email protected]>
(cherry picked from commit 9f81479)
@aasom143 aasom143 changed the title Support cancellation for admin apis (#13966) [Backport 2.x] Support cancellation for admin apis (#13966) Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for b0794ec: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 3, 2024

✅ Gradle check result for 93ae032: SUCCESS

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 31.25000% with 77 lines in your changes missing coverage. Please review.

Project coverage is 71.67%. Comparing base (dbdc151) to head (93ae032).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...admin/cluster/shards/TransportCatShardsAction.java 9.09% 40 Missing ⚠️
...action/support/TimeoutTaskCancellationUtility.java 12.50% 6 Missing and 1 partial ⚠️
.../action/admin/cluster/shards/CatShardsRequest.java 45.45% 6 Missing ⚠️
...action/admin/cluster/shards/CatShardsResponse.java 64.28% 5 Missing ⚠️
...ch/rest/action/admin/cluster/ClusterAdminTask.java 0.00% 5 Missing ⚠️
...g/opensearch/rest/action/cat/RestShardsAction.java 50.00% 5 Missing ⚠️
...ction/admin/cluster/state/ClusterStateRequest.java 33.33% 1 Missing and 1 partial ⚠️
...ction/admin/indices/stats/IndicesStatsRequest.java 33.33% 1 Missing and 1 partial ⚠️
...rch/action/support/broadcast/BroadcastRequest.java 50.00% 2 Missing ⚠️
.../clustermanager/ClusterManagerNodeReadRequest.java 50.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15594      +/-   ##
============================================
- Coverage     71.75%   71.67%   -0.09%     
- Complexity    63980    63991      +11     
============================================
  Files          5239     5244       +5     
  Lines        299084   299174      +90     
  Branches      43540    43540              
============================================
- Hits         214617   214432     -185     
- Misses        66516    66844     +328     
+ Partials      17951    17898      -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shwetathareja shwetathareja merged commit 0028e60 into opensearch-project:2.x Sep 3, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants