Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change version to V_2_17_0 in changes from #15409 #15596

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

ltaragi
Copy link
Contributor

@ltaragi ltaragi commented Sep 3, 2024

Description

Change version to V_2_17_0 in changes from #15409

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Lakshya Taragi <[email protected]>
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❕ Gradle check result for facd3f6: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.92%. Comparing base (41ba00a) to head (facd3f6).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...uster/snapshots/status/SnapshotsStatusRequest.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #15596   +/-   ##
=========================================
  Coverage     71.91%   71.92%           
- Complexity    63864    63873    +9     
=========================================
  Files          5251     5252    +1     
  Lines        298375   298453   +78     
  Branches      43146    43164   +18     
=========================================
+ Hits         214572   214653   +81     
+ Misses        66158    66128   -30     
- Partials      17645    17672   +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock dblock merged commit 0f53bf9 into opensearch-project:main Sep 3, 2024
59 of 61 checks passed
@dblock dblock added the backport 2.x Backport to 2.x branch label Sep 3, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15596-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0f53bf9762f758505a814543ac93c5aaa7bf8e74
# Push it to GitHub
git push --set-upstream origin backport/backport-15596-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15596-to-2.x.

@dblock
Copy link
Member

dblock commented Sep 3, 2024

@ltaragi this will need a manual backport to 2.x please?

ltaragi added a commit to ltaragi/OpenSearch that referenced this pull request Sep 4, 2024
Signed-off-by: Lakshya Taragi <[email protected]>
(cherry picked from commit 0f53bf9)
ltaragi added a commit to ltaragi/OpenSearch that referenced this pull request Sep 4, 2024
Signed-off-by: Lakshya Taragi <[email protected]>
(cherry picked from commit 0f53bf9)
ltaragi added a commit to ltaragi/OpenSearch that referenced this pull request Sep 4, 2024
Signed-off-by: Lakshya Taragi <[email protected]>
(cherry picked from commit 0f53bf9)
sachinpkale pushed a commit that referenced this pull request Sep 4, 2024
Signed-off-by: Lakshya Taragi <[email protected]>
(cherry picked from commit 0f53bf9)
ltaragi added a commit to ltaragi/OpenSearch that referenced this pull request Sep 4, 2024
…ject#15642)

Signed-off-by: Lakshya Taragi <[email protected]>
(cherry picked from commit 0f53bf9)
(cherry picked from commit d368e3b)
ltaragi added a commit to ltaragi/OpenSearch that referenced this pull request Sep 4, 2024
…ject#15642)

Signed-off-by: Lakshya Taragi <[email protected]>
(cherry picked from commit 0f53bf9)
(cherry picked from commit d368e3b)
sachinpkale pushed a commit that referenced this pull request Sep 4, 2024
---------

Signed-off-by: Lakshya Taragi <[email protected]>
(cherry picked from commit 925f41b)

* Remove breaking changes from #15409 (#15624)

Signed-off-by: Lakshya Taragi <[email protected]>
(cherry picked from commit a60b668)
(cherry picked from commit 01b38be)

* Change version to V_2_17_0 (#15596) (#15642)

Signed-off-by: Lakshya Taragi <[email protected]>
(cherry picked from commit 0f53bf9)
(cherry picked from commit d368e3b)
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants