fix wildcard term & terms query & add YAML REST test #15607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HUSTERGS
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah,
jainankitk and
linuxpi
as code owners
github-actions
bot
added
bug
HUSTERGS
force-pushed
the
fix_wildcard_terms_query
branch
from
d347ada
to
d7a17a5
Compare
|
❌ Gradle check result for d347ada: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for d7a17a5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
HUSTERGS
force-pushed
the
fix_wildcard_terms_query
branch
from
d7a17a5
to
57e007e
Compare
|
❌ Gradle check result for 57e007e: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: gesong.samuel <[email protected]>
HUSTERGS
force-pushed
the
fix_wildcard_terms_query
branch
from
57e007e
to
4ac0372
Compare
|
❌ Gradle check result for 4ac0372: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Flaky test failure: #15600 |
Signed-off-by: gesong.samuel <[email protected]>
|
❌ Gradle check result for efa73de: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
dblock
approved these changes
Sep 3, 2024
|
❕ Gradle check result for efa73de: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15607 +/- ##
==========================================
Coverage 71.91% 71.91%
+ Complexity 63864 63842 -22
==========================================
Files 5251 5257 +6
Lines 298375 298543 +168
Branches 43146 43164 +18
==========================================
+ Hits 214572 214699 +127
+ Misses 66158 66148 -10
- Partials 17645 17696 +51 ☔ View full report in Codecov by Sentry. |
dblock
approved these changes
Sep 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
* fix wildcard term & terms query & add YAML REST test Signed-off-by: gesong.samuel <[email protected]> * add CHANGELOG Signed-off-by: gesong.samuel <[email protected]> --------- Signed-off-by: gesong.samuel <[email protected]> Co-authored-by: gesong.samuel <[email protected]> (cherry picked from commit ad1df9e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
msfroh
pushed a commit
that referenced
this pull request
Sep 4, 2024
* fix wildcard term & terms query & add YAML REST test * add CHANGELOG --------- (cherry picked from commit ad1df9e) Signed-off-by: gesong.samuel <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: gesong.samuel <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
* fix wildcard term & terms query & add YAML REST test * add CHANGELOG --------- (cherry picked from commit ad1df9e) Signed-off-by: gesong.samuel <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: gesong.samuel <[email protected]> (cherry picked from commit a737f83) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
msfroh
pushed a commit
that referenced
this pull request
Sep 5, 2024
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
…ect#15607) * fix wildcard term & terms query & add YAML REST test Signed-off-by: gesong.samuel <[email protected]> * add CHANGELOG Signed-off-by: gesong.samuel <[email protected]> --------- Signed-off-by: gesong.samuel <[email protected]> Co-authored-by: gesong.samuel <[email protected]>
This was referenced Sep 11, 2024
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…ect#15607) * fix wildcard term & terms query & add YAML REST test Signed-off-by: gesong.samuel <[email protected]> * add CHANGELOG Signed-off-by: gesong.samuel <[email protected]> --------- Signed-off-by: gesong.samuel <[email protected]> Co-authored-by: gesong.samuel <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…ect#15607) * fix wildcard term & terms query & add YAML REST test Signed-off-by: gesong.samuel <[email protected]> * add CHANGELOG Signed-off-by: gesong.samuel <[email protected]> --------- Signed-off-by: gesong.samuel <[email protected]> Co-authored-by: gesong.samuel <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…ect#15607) * fix wildcard term & terms query & add YAML REST test Signed-off-by: gesong.samuel <[email protected]> * add CHANGELOG Signed-off-by: gesong.samuel <[email protected]> --------- Signed-off-by: gesong.samuel <[email protected]> Co-authored-by: gesong.samuel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix terms related query on wildcard field, original implementation didn't correctly parse the binary string value, causing the search result returns nothing
Related Issues
Resolves #15571
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.