Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.17] [Backport 2.x] [Star Tree] Scaled Float Support #15689

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport c801270 from #15660.

---------

(cherry picked from commit 23f5c2f)

Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c801270)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for da9985c: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for da9985c: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for da9985c: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for da9985c:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for da9985c: SUCCESS

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 20 lines in your changes missing coverage. Please review.

Project coverage is 71.67%. Comparing base (ccae165) to head (da9985c).
Report is 44 commits behind head on 2.17.

Files with missing lines Patch % Lines
...startree/builder/AbstractDocumentsFileManager.java 79.16% 2 Missing and 3 partials ⚠️
...datacube/startree/builder/BaseStarTreeBuilder.java 50.00% 1 Missing and 4 partials ⚠️
...ndex/compositeindex/datacube/DimensionFactory.java 20.00% 0 Missing and 4 partials ⚠️
...pensearch/index/mapper/ScaledFloatFieldMapper.java 60.00% 2 Missing ⚠️
...org/opensearch/index/mapper/NumberFieldMapper.java 87.50% 1 Missing and 1 partial ⚠️
...ube/startree/aggregators/MetricAggregatorInfo.java 75.00% 1 Missing ⚠️
...g/opensearch/index/mapper/DocCountFieldMapper.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.17   #15689      +/-   ##
============================================
- Coverage     71.73%   71.67%   -0.07%     
+ Complexity    64250    64228      -22     
============================================
  Files          5251     5251              
  Lines        300362   300439      +77     
  Branches      43704    43726      +22     
============================================
- Hits         215471   215344     -127     
- Misses        66908    67136     +228     
+ Partials      17983    17959      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta
Copy link
Collaborator

reta commented Sep 16, 2024

The 2.17.0 release has sailed away, this change was not included, @sachinpkale please target 2.17.1 if it is still planned for a possible patch release

@sarthakaggarwal97
Copy link
Contributor

@reta got this merged as a part of this: #15716
Will close this PR. It's outdated! thanks for bringing this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog v2.17.1 Issues and PRs related to version 2.17.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants