Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.17] Integrate translog cleanup with snapshot deletion and fix primary term deletion logic #15750

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7b0846e from #15657.

…m deletion logic (#15657)

---------

Signed-off-by: Sachin Kale <[email protected]>
Co-authored-by: Sachin Kale <[email protected]>
(cherry picked from commit 7b0846e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❕ Gradle check result for 1f86366: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 40.62500% with 76 lines in your changes missing coverage. Please review.

Project coverage is 71.61%. Comparing base (7f08d68) to head (1f86366).
Report is 4 commits behind head on 2.17.

Files with missing lines Patch % Lines
...index/translog/RemoteFsTimestampAwareTranslog.java 40.00% 44 Missing and 1 partial ⚠️
...ch/repositories/blobstore/BlobStoreRepository.java 0.00% 19 Missing ⚠️
...ex/translog/transfer/TranslogTransferMetadata.java 67.85% 6 Missing and 3 partials ⚠️
...dex/translog/transfer/TranslogTransferManager.java 50.00% 1 Missing and 1 partial ⚠️
...ndex/store/RemoteSegmentStoreDirectoryFactory.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.17   #15750      +/-   ##
============================================
- Coverage     71.69%   71.61%   -0.09%     
+ Complexity    64418    64393      -25     
============================================
  Files          5263     5263              
  Lines        301305   301416     +111     
  Branches      43861    43874      +13     
============================================
- Hits         216029   215847     -182     
- Misses        67242    67567     +325     
+ Partials      18034    18002      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale sachinpkale merged commit 01c5e56 into 2.17 Sep 5, 2024
61 of 63 checks passed
@gbbafna gbbafna deleted the backport/backport-15657-to-2.17 branch September 6, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant