Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Adding WithFieldName interface for QueryBuilders with fieldName #15763

Merged
merged 1 commit into from
Sep 9, 2024
Merged

[Backport 2.x] Adding WithFieldName interface for QueryBuilders with fieldName #15763

merged 1 commit into from
Sep 9, 2024

Conversation

dzane17
Copy link
Contributor

@dzane17 dzane17 commented Sep 5, 2024

Description

Backport 2.x #15705

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 7a7cb09: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 7a7cb09: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jainankitk
Copy link
Collaborator

Skipping changelog as the change is already part of 2.17

@dzane17 dzane17 force-pushed the backport/backport-15705-to-2.x branch from 70e9d16 to b6a787a Compare September 5, 2024 23:14
@dzane17
Copy link
Contributor Author

dzane17 commented Sep 5, 2024

@jainankitk I removed CHANGELOG entry

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for 70e9d16: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for b6a787a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for b6a787a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for b6a787a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for b6a787a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dzane17 dzane17 force-pushed the backport/backport-15705-to-2.x branch from b6a787a to a844b6f Compare September 6, 2024 17:53
This was referenced Sep 6, 2024
Open
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for a844b6f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jainankitk
Copy link
Collaborator

Flaky test:

[Test Result](https://build.ci.opensearch.org/job/gradle-check/47513/testReport/) (1 failure / +1)

    [org.opensearch.indices.settings.SearchOnlyReplicaIT.testFailoverWithSearchReplica_WithoutWriterReplicas](https://build.ci.opensearch.org/job/gradle-check/47513/testReport/junit/org.opensearch.indices.settings/SearchOnlyReplicaIT/testFailoverWithSearchReplica_WithoutWriterReplicas/)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for a844b6f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for a844b6f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jainankitk
Copy link
Collaborator

Due to #15812

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for a844b6f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 8, 2024

❌ Gradle check result for a844b6f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jainankitk
Copy link
Collaborator

❌ Gradle check result for a844b6f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Failed due to flaky test:

[Test Result](https://build.ci.opensearch.org/job/gradle-check/47545/testReport/) (1 failure / +1)

    [org.opensearch.search.pit.PitMultiNodeIT.testCreatePitWhileNodeDropWithAllowPartialCreationFalse {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/47545/testReport/junit/org.opensearch.search.pit/PitMultiNodeIT/testCreatePitWhileNodeDropWithAllowPartialCreationFalse__p0___search_concurrent_segment_search_enabled___true___/)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

❌ Gradle check result for a844b6f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

❌ Gradle check result for a844b6f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dzane17
Adding WithFieldName interface for QueryBuilders with fieldName (open…
c643cfa 
…search-project#15705)

Signed-off-by: David Zane <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
Co-authored-by: Ankit Jain <[email protected]>
(cherry picked from commit f5c897c)
@dzane17 dzane17 force-pushed the backport/backport-15705-to-2.x branch from a844b6f to c643cfa Compare September 9, 2024 16:14
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

✅ Gradle check result for c643cfa: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Sep 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.59%. Comparing base (085a2f5) to head (c643cfa).
Report is 1 commits behind head on 2.x.

Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #15763      +/-   ##
============================================
+ Coverage     71.58%   71.59%   +0.01%     
+ Complexity    64509    64495      -14     
============================================
  Files          5264     5264              
  Lines        301993   301993              
  Branches      43962    43962              
============================================
+ Hits         216177   216219      +42     
+ Misses        67735    67700      -35     
+ Partials      18081    18074       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jainankitk jainankitk merged commit 4742400 into opensearch-project:2.x Sep 9, 2024
34 of 35 checks passed
@dzane17 dzane17 deleted the backport/backport-15705-to-2.x branch September 9, 2024 17:26
This was referenced Sep 11, 2024
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jainankitk jainankitk jainankitk approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzane17 @jainankitk