Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log level of noisy message in PublicationTransportHandler #15774

Closed
wants to merge 2 commits into from

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Sep 5, 2024

Description

Change noisy message from info to debug.

I've been testing locally with main and 2.x and this message is flooding logs. I don't think this needs to be default info level.

Related Issues

N/A

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 700e56a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@devvratsaini
Copy link

I am curious why we have this log line if the next if-else block already provides this information - is this log safe to remove altogether? Also, if we still want to keep this log line, why do we want to keep it at debug log level and not at trace log level (like the next log line)?

Signed-off-by: Marc Handalian <[email protected]>
@mch2
Copy link
Member Author

mch2 commented Sep 9, 2024

@devvratsaini I left this as debug thinking it would provide some value without all the noise of trace but your'e right its redundant. Closing this PR though as it was already changed with cbdcbb7#diff-cb8ff1739b8e978957823f979e1f342b90a8e1039764630ba6cf5d291402d659R545

@mch2 mch2 closed this Sep 9, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

❌ Gradle check result for b18f6f4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants