[BUG] Bug fix for checksum validation for mapping metadata #15885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Himshikha Gupta <[email protected]>
himshikha
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15885 +/- ##
============================================
+ Coverage 71.85% 71.91% +0.06%
- Complexity 64213 64235 +22
============================================
Files 5272 5272
Lines 300538 300578 +40
Branches 43432 43432
============================================
+ Hits 215947 216160 +213
+ Misses 66833 66639 -194
- Partials 17758 17779 +21 ☔ View full report in Codecov by Sentry. |
himshikha
added
backport 2.x
Bukhtawar
reviewed
Sep 10, 2024
Code coverage is failing for the |
Signed-off-by: Himshikha Gupta <[email protected]>
Bukhtawar
approved these changes
Sep 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
* Bug fix for checksum validation for mapping metadata Signed-off-by: Himshikha Gupta <[email protected]> (cherry picked from commit f8515c7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
* Bug fix for checksum validation for mapping metadata Signed-off-by: Himshikha Gupta <[email protected]> (cherry picked from commit f8515c7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
himshikha
added a commit
to himshikha/OpenSearch
that referenced
this pull request
Sep 10, 2024
…h-project#15885) * Bug fix for checksum validation for mapping metadata Signed-off-by: Himshikha Gupta <[email protected]>
3 tasks
soosinha
reviewed
Sep 11, 2024
| @@ -169,6 +170,10 @@ public void writeTo(StreamOutput out) throws IOException { | |||
| out.writeByteArray(bytes); | |||
| } | |||
|
|
|||
| public void writeVerifiableTo(BufferedChecksumStreamOutput out) throws IOException { | |||
| out.writeInt(crc32); | |||
There was a problem hiding this comment.
I see that we are ignoring bytes field since that can be different. In that case, should we ingore crc32 as well since this is the checksum and this will be different as well if the bytes are different.
Bukhtawar
pushed a commit
that referenced
this pull request
Sep 12, 2024
…adata #15888 (#15890) * [BUG] Bug fix for checksum validation for mapping metadata (#15885) * Bug fix for checksum validation for mapping metadata Signed-off-by: Himshikha Gupta <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
…adata #15888 (#15890) * [BUG] Bug fix for checksum validation for mapping metadata (#15885) * Bug fix for checksum validation for mapping metadata Signed-off-by: Himshikha Gupta <[email protected]> (cherry picked from commit 1074c71) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Bukhtawar
pushed a commit
that referenced
this pull request
Sep 12, 2024
…adata #15888 (#15890) (#15908) * [BUG] Bug fix for checksum validation for mapping metadata (#15885) Signed-off-by: Himshikha Gupta <[email protected]>
reta
added
v2.18.0
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…h-project#15885) * Bug fix for checksum validation for mapping metadata Signed-off-by: Himshikha Gupta <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…h-project#15885) * Bug fix for checksum validation for mapping metadata Signed-off-by: Himshikha Gupta <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…h-project#15885) * Bug fix for checksum validation for mapping metadata Signed-off-by: Himshikha Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During checksum validation for remote cluster state, for mapping metadata we need to ignore compressed data check.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.