-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky terminaton conditions for org.opensearch.rest.ReactorNetty4StreamingStressIT.testCloseClientStreamingRequest test case #15959
Conversation
…StreamingStressIT.testCloseClientStreamingRequest test case Signed-off-by: Andriy Redko <[email protected]>
@mch2 may I ask you please to take a look? thank you! |
❌ Gradle check result for 85ebbb0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15959 +/- ##
============================================
- Coverage 71.93% 71.84% -0.10%
+ Complexity 64374 64306 -68
============================================
Files 5277 5277
Lines 300828 300828
Branches 43474 43474
============================================
- Hits 216411 216126 -285
- Misses 66725 66953 +228
- Partials 17692 17749 +57 ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15959-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 eb5b70370e548cd0f3b51721397df818b3050daa
# Push it to GitHub
git push --set-upstream origin backport/backport-15959-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…StreamingStressIT.testCloseClientStreamingRequest test case (opensearch-project#15959) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit eb5b703)
…StreamingStressIT.testCloseClientStreamingRequest test case (#15959) (#15962) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit eb5b703)
…StreamingStressIT.testCloseClientStreamingRequest test case (opensearch-project#15959) Signed-off-by: Andriy Redko <[email protected]>
…StreamingStressIT.testCloseClientStreamingRequest test case (opensearch-project#15959) Signed-off-by: Andriy Redko <[email protected]>
…StreamingStressIT.testCloseClientStreamingRequest test case (opensearch-project#15959) Signed-off-by: Andriy Redko <[email protected]>
…StreamingStressIT.testCloseClientStreamingRequest test case (opensearch-project#15959) Signed-off-by: Andriy Redko <[email protected]>
Description
Followup on this comment #15859 (comment), removal of the
ConnectionClosedException
was premature:Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.