Refactor branch deletion for backports #15983
Conversation
Signed-off-by: Sayali Gaikawad <[email protected]>
There was a problem hiding this comment.
Food for thought; I'd rather we have a sweep and clean job on a cron trigger that looked for merged/closed backport/ branches and then deleted them that tying this to PR actions. That would also address all those not-yet-deleted branches that are hanging out.
peternied
added
backport 2.x
|
@gaiksaya I'll merge and lets check back in tomorrow to see if this is working. |
Sure! Thanks! Please merge when you see fit. |
Signed-off-by: Sayali Gaikawad <[email protected]>
|
Hi @peternied @kotwanikunal Do we need to backport this to 2.x? |
|
Looks like indentation issue. Fixed here: #16003 |
|
Also looks like the workflows in the merged branches are the ones that run. Hence, need to backport in order to delete branches for the PRs that get merged in 2.x |
|
@gaiksaya Can you create the backport pr to do this? |
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Description
Refactor branch deletion for backports as current workflow has been failing 2 months.
https://github.com/opensearch-project/OpenSearch/actions/workflows/delete_backport_branch.yml
The author of the currently used action specified that it is no longer maintained. SvanBoxel/delete-merged-branch#257 (comment)
Hence, refactoring to use GH scripts. Works as expected. See https://github.com/gaiksaya/opensearch-build-libraries/actions/runs/10930031518
Related Issues
Resolves #15984
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.