Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Star tree] Star tree file formats refactoring and fixing offset bug #15991

Merged
merged 1 commit into from
Oct 14, 2024
Merged

[Backport 2.x] [Star tree] Star tree file formats refactoring and fixing offset bug #15991

merged 1 commit into from
Oct 14, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 80ff07e from #15975.

@github-actions
star tree file formats refactoring and fixing offset bug (#15975)
732aa12 
Signed-off-by: Bharathwaj G <[email protected]>
(cherry picked from commit 80ff07e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 732aa12: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.04918% with 14 lines in your changes missing coverage. Please review.

Project coverage is 71.66%. Comparing base (94d04ff) to head (732aa12).
Report is 106 commits behind head on 2.x.

Files with missing lines Patch % Lines
...be/startree/utils/SequentialDocValuesIterator.java 68.75% 2 Missing and 3 partials ⚠️
...cube/startree/builder/StarTreeDocsFileManager.java 50.00% 1 Missing and 2 partials ⚠️
...eindex/datacube/startree/index/StarTreeValues.java 76.92% 1 Missing and 2 partials ⚠️
...tartree/utils/iterator/StarTreeValuesIterator.java 57.14% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #15991      +/-   ##
============================================
- Coverage     71.70%   71.66%   -0.04%     
+ Complexity    64632    64627       -5     
============================================
  Files          5269     5278       +9     
  Lines        302191   302295     +104     
  Branches      43989    43990       +1     
============================================
- Hits         216679   216640      -39     
- Misses        67376    67599     +223     
+ Partials      18136    18056      -80

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit 9eaa7ae into 2.x Oct 14, 2024
58 of 60 checks passed
@github-actions github-actions bot deleted the backport/backport-15975-to-2.x branch October 14, 2024 05:53
@dbwiddis dbwiddis mentioned this pull request Oct 14, 2024
Closed
3 tasks
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandeshkr419 sandeshkr419 sandeshkr419 approved these changes

@dbwiddis dbwiddis dbwiddis approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbwiddis @sandeshkr419