Fixed primary shard balance constraints getting unset

[patelsmit32123]

Description

Fixed updating shard balance factor and other such settings were unsetting the prefer primary shard balance constraints.

Related Issues

#13429

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[patelsmit32123]

@peternied Can you please review?

[github-actions]

❌ Gradle check result for 360fbfa: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for f161334: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❕ Gradle check result for ca907c7: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.99%. Comparing base (3937ccb) to head (ca907c7).
Report is 170 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #15996      +/-   ##
============================================
+ Coverage     71.90%   71.99%   +0.08%     
- Complexity    64392    64393       +1     
============================================
  Files          5278     5280       +2     
  Lines        300877   300875       -2     
  Branches      43478    43477       -1     
============================================
+ Hits         216351   216619     +268     
+ Misses        66747    66474     -273     
- Partials      17779    17782       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[peternied]

@patelsmit32123 Thanks for making this change and reaching out.

@gbbafna @Bukhtawar @ashking94 Could one of you review this PR in my place?

[ashking94]

@patelsmit32123 Thanks for making this change and reaching out.

@gbbafna @Bukhtawar @ashking94 Could one of you review this PR in my place?

Hi @peternied, I will review this. Thanks @patelsmit32123 for making this change. Allow me some time to go over this.

[ashking94]

Can we add a test (unit test or ITs) that covers the scenario mentioned in the issue #13429? The changes seem fine otherwise.

[patelsmit32123]

@ashking94 how to test the scenario? The problem is that the allocation constraints which are getting unset, they are not accessible from outside.

[ashking94]

@ashking94 how to test the scenario? The problem is that the allocation constraints which are getting unset, they are not accessible from outside.

Can we add some unit tests to ascertain that the behaviour works as expected? I see BalancedSingleShardTests where you can attempt to put the test against the delta. Let me know if this does not work.

[opensearch-trigger-bot]

This PR is stalled because it has been open for 30 days with no activity.