-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Star tree] Performance optimizations during flush flow #16037
[Star tree] Performance optimizations during flush flow #16037
Conversation
bc627ec
to
9476b03
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16037 +/- ##
============================================
+ Coverage 71.89% 71.93% +0.03%
- Complexity 64750 64758 +8
============================================
Files 5307 5307
Lines 302664 302714 +50
Branches 43726 43733 +7
============================================
+ Hits 217612 217743 +131
+ Misses 67183 67117 -66
+ Partials 17869 17854 -15 ☔ View full report in Codecov by Sentry. |
0175201
to
f77f98f
Compare
❌ Gradle check result for f77f98f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
f77f98f
to
4e1a100
Compare
❌ Gradle check result for 4e1a100: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 4e1a100: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Bharathwaj G <[email protected]>
Signed-off-by: Bharathwaj G <[email protected]>
4e1a100
to
00bab32
Compare
--------- Signed-off-by: Bharathwaj G <[email protected]> (cherry picked from commit dc8a435) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) --------- (cherry picked from commit dc8a435) Signed-off-by: Bharathwaj G <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…roject#16037) --------- Signed-off-by: Bharathwaj G <[email protected]>
…roject#16037) --------- Signed-off-by: Bharathwaj G <[email protected]>
Description
Currently we initialize metric readers for all metric stats, thereby duplicating field value for each of the stats, when we write star tree document in off heap method.
If we initialize metric readers per metric field instead, we can write and read only the actual field values and when we read and initialize the star tree document, we can set the field's value to all metric stats.
We can buffer each starTreeDocument in memory and write bytes to indexOutput.
Related Issues
#16218
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.