Add support for docker compose v2 in TestFixturesPlugin #16049
Merged
+19
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
Signed-off-by: Craig Perkins <[email protected]>
cwperks
changed the title
cwperks
changed the title
Signed-off-by: Craig Perkins <[email protected]>
cwperks
force-pushed
the
update-docker-compose
branch
from
fd11a18
to
4b6ecf8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16049 +/- ##
============================================
- Coverage 71.99% 71.89% -0.11%
+ Complexity 64408 64362 -46
============================================
Files 5281 5281
Lines 301003 301010 +7
Branches 43483 43486 +3
============================================
- Hits 216721 216413 -308
- Misses 66522 66798 +276
- Partials 17760 17799 +39 ☔ View full report in Codecov by Sentry. |
dblock
approved these changes
Sep 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
* Update references for docker-compose to docker compose Signed-off-by: Craig Perkins <[email protected]> * Support both Signed-off-by: Craig Perkins <[email protected]> * Check if V2 is available Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Update CHANGELOG text Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 6a29119) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While looking into upgrading google dependencies to v2, I ran into an issue where docker compose related gradle tasks were being skipped on my Mac due to
docker-composenot being present. This PR adds support for Docker Compose V2 (docker compose- without the hyphen)Related Issues
Resolves: #16050
Dependabot updates have been failing for google related dependencies due to major version upgrade. Example: #16043
opensearch-api-specification repo did a similar update: opensearch-project/opensearch-api-specification#457
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.