Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Remote State and Publication enabled and configured methods #16080

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

shiv0408
Copy link
Member

@shiv0408 shiv0408 commented Sep 25, 2024

Description

Currently we have references to isRemoteStateEnabled and isRemotePublicationEnabled methods at multiple places. We want to create different methods isRemoteStateConfigured and isRemotePublicationConfigured, which will return true if node attributes are present on the node.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 60fbfea: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 69b1724: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for e5d3abc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 87a8e84: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 831359c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 122a549: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for cfcb605: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.94%. Comparing base (8ddb3ee) to head (9f59e2b).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
...g/opensearch/cluster/coordination/Coordinator.java 25.00% 2 Missing and 1 partial ⚠️
...search/cluster/coordination/CoordinationState.java 0.00% 0 Missing and 1 partial ⚠️
...arch/gateway/remote/RemoteClusterStateService.java 50.00% 0 Missing and 1 partial ⚠️
...ensearch/index/remote/RemoteIndexPathUploader.java 0.00% 0 Missing and 1 partial ⚠️
...rch/node/remotestore/RemoteStoreNodeAttribute.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16080      +/-   ##
============================================
+ Coverage     71.86%   71.94%   +0.08%     
- Complexity    64447    64500      +53     
============================================
  Files          5288     5288              
  Lines        301438   301436       -2     
  Branches      43552    43551       -1     
============================================
+ Hits         216628   216878     +250     
+ Misses        67034    66797     -237     
+ Partials      17776    17761      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

❌ Gradle check result for 70947b5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Shivansh Arora <[email protected]>
Copy link
Contributor

github-actions bot commented Oct 1, 2024

✅ Gradle check result for 9f59e2b: SUCCESS

@shwetathareja shwetathareja merged commit 5771e81 into opensearch-project:main Oct 3, 2024
34 of 36 checks passed
@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Oct 3, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 3, 2024
…16080)

* Separate Remote State and Publication enabled and configured methods

Signed-off-by: Shivansh Arora <[email protected]>
(cherry picked from commit 5771e81)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
soosinha pushed a commit to soosinha/OpenSearch that referenced this pull request Oct 9, 2024
…pensearch-project#16080)

* Separate Remote State and Publication enabled and configured methods

Signed-off-by: Shivansh Arora <[email protected]>
gbbafna pushed a commit that referenced this pull request Oct 10, 2024
…igured methods (#16249)

* Separate Remote State and Publication enabled and configured methods (#16080)

* Separate Remote State and Publication enabled and configured methods

Signed-off-by: Shivansh Arora <[email protected]>

* Revert remote publication method renaming in DiscoveryNode (#16250)

Signed-off-by: Sooraj Sinha <[email protected]>

---------

Signed-off-by: Shivansh Arora <[email protected]>
Signed-off-by: Sooraj Sinha <[email protected]>
Co-authored-by: Shivansh Arora <[email protected]>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
…pensearch-project#16080)

* Separate Remote State and Publication enabled and configured methods

Signed-off-by: Shivansh Arora <[email protected]>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
…pensearch-project#16080)

* Separate Remote State and Publication enabled and configured methods

Signed-off-by: Shivansh Arora <[email protected]>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
…pensearch-project#16080)

* Separate Remote State and Publication enabled and configured methods

Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants