-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate Remote State and Publication enabled and configured methods #16080
Separate Remote State and Publication enabled and configured methods #16080
Conversation
❌ Gradle check result for 60fbfea: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
60fbfea
to
69b1724
Compare
❌ Gradle check result for 69b1724: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for e5d3abc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
e5d3abc
to
87a8e84
Compare
❌ Gradle check result for 87a8e84: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
87a8e84
to
831359c
Compare
❌ Gradle check result for 831359c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 122a549: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for cfcb605: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16080 +/- ##
============================================
+ Coverage 71.86% 71.94% +0.08%
- Complexity 64447 64500 +53
============================================
Files 5288 5288
Lines 301438 301436 -2
Branches 43552 43551 -1
============================================
+ Hits 216628 216878 +250
+ Misses 67034 66797 -237
+ Partials 17776 17761 -15 ☔ View full report in Codecov by Sentry. |
server/src/internalClusterTest/java/org/opensearch/gateway/remote/RemoteStatePublicationIT.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Shivansh Arora <[email protected]>
cfcb605
to
70947b5
Compare
❌ Gradle check result for 70947b5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Shivansh Arora <[email protected]>
…16080) * Separate Remote State and Publication enabled and configured methods Signed-off-by: Shivansh Arora <[email protected]> (cherry picked from commit 5771e81) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…pensearch-project#16080) * Separate Remote State and Publication enabled and configured methods Signed-off-by: Shivansh Arora <[email protected]>
…igured methods (#16249) * Separate Remote State and Publication enabled and configured methods (#16080) * Separate Remote State and Publication enabled and configured methods Signed-off-by: Shivansh Arora <[email protected]> * Revert remote publication method renaming in DiscoveryNode (#16250) Signed-off-by: Sooraj Sinha <[email protected]> --------- Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: Sooraj Sinha <[email protected]> Co-authored-by: Shivansh Arora <[email protected]>
…pensearch-project#16080) * Separate Remote State and Publication enabled and configured methods Signed-off-by: Shivansh Arora <[email protected]>
…pensearch-project#16080) * Separate Remote State and Publication enabled and configured methods Signed-off-by: Shivansh Arora <[email protected]>
…pensearch-project#16080) * Separate Remote State and Publication enabled and configured methods Signed-off-by: Shivansh Arora <[email protected]>
Description
Currently we have references to
isRemoteStateEnabled
andisRemotePublicationEnabled
methods at multiple places. We want to create different methodsisRemoteStateConfigured
andisRemotePublicationConfigured
, which will return true if node attributes are present on the node.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.