Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.3] Bugfix to guard against stack overflow errors caused by very large reg-ex input #16101

Merged
merged 3 commits into from
Oct 10, 2024

Commits on Sep 26, 2024

  1. Bugfix to guard against stack overflow errors caused by very large re…

    …g-ex input (#2810)
    
    * Bugfix to guard against stack overflow errors caused by very large reg-ex input
    
    This change fixes a code path that did not properly impose the index-level max_regex_length limit. Therefore, it was possibly to provide ar arbitrarily large string as the include/exclude reg-ex value under search aggregations. This exposed the underlying node to crashes from a StackOverflowError, due to how the Lucene RegExp class processes strings using stack frames.
    
    Signed-off-by: Kartik Ganesh <[email protected]>
    
    * Adding integration tests for large string RegEx
    
    Signed-off-by: Kartik Ganesh <[email protected]>
    
    * Spotless
    
    Signed-off-by: Kartik Ganesh <[email protected]>
    (cherry picked from commit 566ebfa)
    Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
    github-actions[bot] committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    fabde0c View commit details
    Browse the repository at this point in the history
  2. Use JDK8 compatible string repetition

    Signed-off-by: Daniel Widdis <[email protected]>
    dbwiddis committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    f86d44e View commit details
    Browse the repository at this point in the history
  3. Change log

    Signed-off-by: Daniel Widdis <[email protected]>
    dbwiddis committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    7eca19d View commit details
    Browse the repository at this point in the history