Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Star Tree] [Search] Support for metric aggregations with/without term query #16416

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

sandeshkr419
Copy link
Contributor

@sandeshkr419 sandeshkr419 commented Oct 21, 2024

Description

Backport #15289 to 2.x

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❕ Gradle check result for 9b77ab1: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 83.61204% with 49 lines in your changes missing coverage. Please review.

Project coverage is 71.82%. Comparing base (a31e7f2) to head (9b77ab1).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
...x/datacube/startree/utils/StarTreeQueryHelper.java 71.60% 8 Missing and 15 partials ⚠️
...rch/search/aggregations/metrics/AvgAggregator.java 78.78% 2 Missing and 5 partials ⚠️
...org/opensearch/search/startree/StarTreeFilter.java 93.13% 1 Missing and 6 partials ⚠️
...ensearch/search/startree/StarTreeQueryContext.java 75.00% 2 Missing and 2 partials ⚠️
...main/java/org/opensearch/search/SearchService.java 75.00% 1 Missing and 2 partials ⚠️
...h/index/compositeindex/datacube/DateDimension.java 0.00% 1 Missing ⚠️
...h/index/compositeindex/datacube/ReadDimension.java 0.00% 1 Missing ⚠️
...rch/aggregations/metrics/AvgAggregatorFactory.java 0.00% 1 Missing ⚠️
...rch/aggregations/metrics/MinAggregatorFactory.java 0.00% 1 Missing ⚠️
...regations/metrics/ValueCountAggregatorFactory.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #16416      +/-   ##
============================================
- Coverage     71.91%   71.82%   -0.09%     
- Complexity    65221    65250      +29     
============================================
  Files          5308     5312       +4     
  Lines        304350   304646     +296     
  Branches      44268    44324      +56     
============================================
- Hits         218867   218813      -54     
- Misses        67234    67543     +309     
- Partials      18249    18290      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit 5617340 into opensearch-project:2.x Oct 21, 2024
65 of 66 checks passed
@sandeshkr419 sandeshkr419 deleted the st0-2x branch October 22, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants