[Remove] types from PutMappingRequest #2335

nknize · 2022-03-04T00:27:59Z

Remove type support from putMappingRequest, dependencies, and all tests.

relates #1940

opensearch-ci-bot · 2022-03-04T00:28:03Z

Can one of the admins verify this patch?

opensearch-ci-bot · 2022-03-04T00:33:25Z

❌ Gradle Check failure 9f2912acefcc74760ccbb6432674934625fd1530
Log 3005

Reports 3005

opensearch-ci-bot · 2022-03-04T00:36:56Z

❌ Gradle Check failure b6eda0e4ea3155392a5d8957b8729a19e155b1da
Log 3006

Reports 3006

opensearch-ci-bot · 2022-03-04T01:00:31Z

❌ Gradle Check failure 8e71e967b9da95e55ac66d7110e64b6f91f8130b
Log 3008

Reports 3008

dreamer-89 · 2022-03-04T03:20:36Z

The latest job fails testThatUpdatingMappingShouldNotRemoveSizeMappingConfiguration test due to assertion error.

REPRODUCE WITH: ./gradlew ':plugins:mapper-size:internalClusterTest' --tests "org.opensearch.index.mapper.size.SizeMappingIT.testThatUpdatingMappingShouldNotRemoveSizeMappingConfiguration" -Dtests.seed=4F62945A913A057D -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=pt -Dtests.timezone=Australia/Currie -Druntime.java=17

org.opensearch.index.mapper.size.SizeMappingIT > testThatUpdatingMappingShouldNotRemoveSizeMappingConfiguration FAILED
    java.lang.AssertionError: Expected size field mapping to be enabled for foo
    Expected: map containing ["_size"->ANYTHING]
         but: map was [<properties={otherField={type=text}}>]
        at __randomizedtesting.SeedInfo.seed([4F62945A913A057D:D988F27324556493]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:964)
        at org.opensearch.index.mapper.size.SizeMappingIT.assertSizeMappingEnabled(SizeMappingIT.java:119)
        at org.opensearch.index.mapper.size.SizeMappingIT.testThatUpdatingMappingShouldNotRemoveSizeMappingConfiguration(SizeMappingIT.java:85)
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.gradle.api.internal.tasks.testing.worker.TestWorker (file:/home/ubuntu/.gradle/wrapper/dists/gradle-7.3.3-all/4295vidhdd9hd3gbjyw1xqxpo/gradle-7.3.3/lib/plugins/gradle-testing-base-7.3.3.jar)
WARNING: Please consider reporting this to the maintainers of org.gradle.api.internal.tasks.testing.worker.TestWorker
WARNING: System::setSecurityManager will be removed in a future release

dreamer-89 · 2022-03-04T03:20:46Z

start gradle check

nknize · 2022-03-04T03:22:01Z

There are still a few other failures as well.. Getting ready to push an update

opensearch-ci-bot · 2022-03-04T03:39:00Z

❌ Gradle Check failure 8e71e967b9da95e55ac66d7110e64b6f91f8130b
Log 3011

Reports 3011

opensearch-ci-bot · 2022-03-04T03:53:22Z

❌ Gradle Check failure 54cf66eedd8e9822a3296afed435783464a723c7
Log 3013

Reports 3013

opensearch-ci-bot · 2022-03-04T04:00:25Z

❌ Gradle Check failure f08f97bbfd6d52ea486a162c22dd7c1ecc916339
Log 3014

Reports 3014

opensearch-ci-bot · 2022-03-04T04:04:32Z

❌ Gradle Check failure 5895febddfb05a506e7da4dbe0afd9ff05ff7f6a
Log 3015

Reports 3015

opensearch-ci-bot · 2022-03-04T04:36:38Z

❌ Gradle Check failure 012ad3fff367a24820cccb6adf15e5e06a7ca2f2
Log 3017

Reports 3017

dreamer-89 · 2022-03-04T04:58:20Z

Multiple failures. Out of these, testRecoverReplica fails more frequently on Jenkins but is not reproducible on local machine.

TranslogPolicyIT.testRecoverReplica failure.

REPRODUCE WITH: ./gradlew ':qa:translog-policy:v1.3.0#Step1OldClusterTest' --tests "org.opensearch.upgrades.TranslogPolicyIT.testRecoverReplica" -Dtests.seed=A7F39AB3B5FF3CF9 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=mt -Dtests.timezone=Chile/Continental -Druntime.java=17

org.opensearch.upgrades.TranslogPolicyIT > testRecoverReplica FAILED
    org.opensearch.client.WarningFailureException: method [PUT], host [http://127.0.0.1:33619], URI [/testrecoverreplica], status line [HTTP/1.1 200 OK]
    {"acknowledged":true,"shards_acknowledged":true,"index":"testrecoverreplica"}
        at __randomizedtesting.SeedInfo.seed([A7F39AB3B5FF3CF9:5D6A55174026FDF4]:0)
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:346)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:320)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:295)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:976)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:956)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:952)
        at app//org.opensearch.upgrades.TranslogPolicyIT.testRecoverReplica(TranslogPolicyIT.java:129)

testOperationBasedRecovery

REPRODUCE WITH: ./gradlew ':qa:full-cluster-restart:v1.3.0#oldClusterTest' --tests "org.opensearch.upgrades.FullClusterRestartIT.testOperationBasedRecovery" -Dtests.seed=A7F39AB3B5FF3CF9 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-CR -Dtests.timezone=America/Argentina/San_Juan -Druntime.java=17

org.opensearch.upgrades.FullClusterRestartIT > testOperationBasedRecovery FAILED
    org.opensearch.client.WarningFailureException: method [PUT], host [http://127.0.0.1:35135], URI [/testoperationbasedrecovery], status line [HTTP/1.1 200 OK]
    {"acknowledged":true,"shards_acknowledged":true,"index":"testoperationbasedrecovery"}
        at __randomizedtesting.SeedInfo.seed([A7F39AB3B5FF3CF9:BA1F9696B379C68E]:0)
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:346)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:320)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:295)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:976)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:956)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:952)
        at app//org.opensearch.upgrades.FullClusterRestartIT.testOperationBasedRecovery(FullClusterRestartIT.java:1289)

testEnableSoftDeletesOnRestore

  2> REPRODUCE WITH: ./gradlew ':qa:full-cluster-restart:v1.3.0#oldClusterTest' --tests "org.opensearch.upgrades.FullClusterRestartIT.testEnableSoftDeletesOnRestore" -Dtests.seed=A7F39AB3B5FF3CF9 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-CR -Dtests.timezone=America/Argentina/San_Juan -Druntime.java=17
  2> org.opensearch.client.WarningFailureException: method [PUT], host [http://127.0.0.1:35135], URI [/testenablesoftdeletesonrestore], status line [HTTP/1.1 200 OK]
    {"acknowledged":true,"shards_acknowledged":true,"index":"testenablesoftdeletesonrestore"}
        at __randomizedtesting.SeedInfo.seed([A7F39AB3B5FF3CF9:93AC5E1A696C82C2]:0)
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:346)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:320)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:295)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:976)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:956)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:952)

nknize · 2022-03-04T05:00:53Z

This test has started failing more frequently on Jenkins but this test is not reproducible on local machine

I thought I was going crazy! This is tripping up in RestClient.java#L345 which could be related to types removal warning but the exception doesn't print the offending warning. We should add that and try to reproduce in jenkins.

dreamer-89 · 2022-03-04T05:19:31Z

This test has started failing more frequently on Jenkins but this test is not reproducible on local machine

I thought I was going crazy! This is tripping up in RestClient.java#L345 which could be related to types removal warning but the exception doesn't print the offending warning. We should add that and try to reproduce in jenkins.

Raised PR to log warnings #2338

VachaShah · 2022-03-04T06:23:33Z

@nknize @dreamer-89 This might be related to #2334. I am working on a fix for this.

dblock · 2022-03-04T15:07:40Z

start gradle check

reta · 2022-03-04T15:34:38Z

@nknize LGTM but it looks incomplete (to me), the PutMappingRequest still uses type in payload:

{
  "_doc": {
    "properties": {
      "name": {
        "type": "text",
   ....
}

I think it would be great to remove it as well in scope of this change, wdyt?

opensearch-ci-bot · 2022-03-04T15:49:19Z

❌ Gradle Check failure 012ad3fff367a24820cccb6adf15e5e06a7ca2f2
Log 3029

Reports 3029

nknize · 2022-03-04T16:06:23Z

TranslogPolicyIT is no longer needed. This was added to trim unsafe commits for indexes created before 6.2. This is failing now because Step1OldClusterTest applies to 7.x/1.x indices whereas it used to be Legacy 6.2. There's a PR open #2225 that removes all of this ancient logic.

nknize · 2022-03-04T16:06:43Z

Until the PR is merged I'm going to unilaterly push a MuteTest commit.

nknize · 2022-03-04T16:11:59Z

I'm going to unilaterly push a MuteTest commit.

As a good steward I opened a PR instead. #2342

reta · 2022-03-04T16:40:39Z

I'm going to unilaterly push a MuteTest commit.

As a good steward I opened a PR instead. #2342

@nknize could we get #2225 in before merging this one?

nknize · 2022-03-04T16:51:03Z

@nknize could we get #2225 in before merging this one?

Yes. It needs to land before this can be merged.

I think it would be great to remove it as well in scope of this change, wdyt?

I noticed a few more removals needed for this PR that I think will bring this one to ready. Then we can continue to detangle in follow up PRs.

Remove type support from putMappingRequest, dependencies, and all tests. Signed-off-by: Nicholas Walter Knize <[email protected]>

Signed-off-by: Nicholas Walter Knize <[email protected]>

opensearch-ci-bot · 2022-03-04T17:36:09Z

❌ Gradle Check failure 6cf60d9
Log 3037

Reports 3037

Signed-off-by: Nicholas Walter Knize <[email protected]>

opensearch-ci-bot · 2022-03-04T18:47:44Z

✅ Gradle Check success e7b59ab
Log 3045

Reports 3045

dreamer-89

LGTM!

dreamer-89 · 2022-03-04T18:56:10Z

client/rest-high-level/src/main/java/org/opensearch/client/IndicesClient.java

-            emptySet()
-        );
-    }
-
    /**


Are other deprecated methods e.g. getFieldMapping, getFieldMappingAsync etc; also under your radar for removal ?

Yes! Upcoming PR

This includes the following: commit 9cfa395 Author: Kartik <[email protected]> Date: Thu Mar 10 10:12:17 2022 -0800 Remove the IndexCommitRef class (opensearch-project#2421) This inner class is no longer required because its functionality has been moved to the generic GatedCloseable class. Signed-off-by: Kartik Ganesh <[email protected]> commit c8d8009 Author: Andriy Redko <[email protected]> Date: Thu Mar 10 11:46:08 2022 -0500 Fixing bwcVersions and bwc builds (opensearch-project#2430) - adding 1.4.0 into main bwcVersions Signed-off-by: Andriy Redko <[email protected]> commit fb9e150 Author: Kartik <[email protected]> Date: Wed Mar 9 12:21:09 2022 -0800 Refactoring gated and ref-counted interfaces and their implementations (opensearch-project#2396) * Reducing duplication in plugins around ref-counted releasable classes Both AmazonEc2Reference and AmazonS3Reference duplicate the same logic - a subclass of AbstractRefCounted that also implements Releasable. This change centralizes this paradigm into a AbstractRefCountedReleasable class and supports both clients via generics. It also updates all fetching implementations to use the get() method instead of client() Signed-off-by: Kartik Ganesh <[email protected]> * Introduce Reference classes for the Closeable and AutoCloseable interfaces These classes allow you to wrap a reference instance with an onClose runnable that is executed when close() is invoked. Two separate classes are needed because the close() signatures for the two interfaces are different. This change takes the first step to have implementing classes extend from these generic superclasses, before attempting to remove the subclasses entirely. The get() method is also replaced throughout the code base. Note that there is also a separate Releasable interface that has a similar access pattern, but is implemented separately. This is used in AbstractRefCountedReleasable introduced in a prior commit Signed-off-by: Kartik Ganesh <[email protected]> * More improvements and refactoring * Functionality around one-way gating is now moved to a dedicated class - OneWayGate. This replaces duplicate functionality throughout the code. * The two *Reference classes have been renamed to Gated* since that better represents their functionality * The AbstractRefCountedReleasable has been improved to no longer be abstract by accepting the shutdown hook. This removes the need for the inner class in ReleasableBytesReference, and further simplifies the plugin subclasses (these could probably be removed entirely). * Finally, unit tests have been added for some classes Signed-off-by: Kartik Ganesh <[email protected]> * Added tests for GatedCloseable Also updated the license information in GatedAutoCloseableTests Signed-off-by: Kartik Ganesh <[email protected]> * Fixing license information in new files Signed-off-by: Kartik Ganesh <[email protected]> * Added unit tests for RefCountedReleasable Signed-off-by: Kartik Ganesh <[email protected]> commit 5a9a114 Author: Nick Knize <[email protected]> Date: Wed Mar 9 12:50:05 2022 -0600 [Remove] TrimUnsafeCommit logic for legacy 6.x indexes (opensearch-project#2225) * [Remove] TrimUnsafeCommit logic for legacy 6.x indexes Multiple txlog commits was introduced in legacy 7.x. Legacy 6.x indexes could therefore not have a safe commit. Since OpenSearch 2.0 is no longer compatible with legacy 6.x indexes, the logic to trim these unsafe commits is safely removed. Signed-off-by: Nicholas Walter Knize <[email protected]> * fix assertion typo Signed-off-by: Nicholas Walter Knize <[email protected]> * rebase and incorporate pr feedback Signed-off-by: Nicholas Walter Knize <[email protected]> commit 9c679cb Author: Andriy Redko <[email protected]> Date: Tue Mar 8 18:42:32 2022 -0500 MapperService has to be passed in as null for EnginePlugins CodecService constructor (opensearch-project#2177) * MapperService has to be passed in as null for EnginePlugins CodecService constructor Signed-off-by: Andriy Redko <[email protected]> * Addressing code review comments Signed-off-by: Andriy Redko <[email protected]> * Delayed CodecService instantiation up to the shard initialization Signed-off-by: Andriy Redko <[email protected]> * Added logger (associated with shard) to CodecServiceConfig Signed-off-by: Andriy Redko <[email protected]> * Refactored the EngineConfigFactory / IndexShard instantiation of the CodecService Signed-off-by: Andriy Redko <[email protected]> commit a6a47e7 Author: Suraj Singh <[email protected]> Date: Tue Mar 8 14:43:04 2022 -0800 Remove inclue_type_name parameter from rest api spec (opensearch-project#2410) Signed-off-by: Suraj Singh <[email protected]> commit 044f536 Author: Daniel Doubrovkine (dB.) <[email protected]> Date: Tue Mar 8 14:48:51 2022 -0500 Set target and source compatibility to 11, required by Lucene 9. (opensearch-project#2407) * Set target and source compatibility to 11, required by Lucene 9. Signed-off-by: dblock <[email protected]> * Uncomment commented code in opensearch-project#2321 for killing child processes that uses JDK9+ ProcessInfo. Signed-off-by: dblock <[email protected]> * Set distribution checker target JDK compatibility to 11. Signed-off-by: dblock <[email protected]> * Supress processing warnings. Signed-off-by: dblock <[email protected]> commit c3712a5 Author: Nick Knize <[email protected]> Date: Tue Mar 8 11:30:27 2022 -0600 [Remove] include_type_name from HLRC (opensearch-project#2397) Removes include_type_name from the high level reset client along with relevant deprecated methods in IndicesClient. All tests are updated to remove the parameter from the rest requests along with various toXContent methods that are no longer required. Signed-off-by: Nicholas Walter Knize <[email protected]> commit 63c75d1 Author: Tianli Feng <[email protected]> Date: Tue Mar 8 08:35:36 2022 -0800 Deprecate setting 'reindex.remote.whitelist' and introduce the alternative setting 'reindex.remote.allowlist' (opensearch-project#2221) * Add setting reindex.remote.allowlist, and deprecate setting reindex.remote.whitelist Signed-off-by: Tianli Feng <[email protected]> * Add unit test for renaming the setting reindex.remote.allowlist Signed-off-by: Tianli Feng <[email protected]> * Remove system.out.println() Signed-off-by: Tianli Feng <[email protected]> * Adjust format by spotlessApply task Signed-off-by: Tianli Feng <[email protected]> * Replace REMOTE_CLUSTER_WHITELIST with REMOTE_CLUSTER_ALLOWLIST Signed-off-by: Tianli Feng <[email protected]> * Add a unit test to test final setting value when both settings have got a value Signed-off-by: Tianli Feng <[email protected]> * Rename the unit test class name Signed-off-by: Tianli Feng <[email protected]> * Remove the Access modifiers public from the constant REMOTE_CLUSTER_WHITELIST Signed-off-by: Tianli Feng <[email protected]> * Initialize ReindexPlugin without using the @before method Signed-off-by: Tianli Feng <[email protected]> * Rename 'unwhitelisted' to 'unallowlisted' in a yml file used for REST api testing. Signed-off-by: Tianli Feng <[email protected]> commit 65debde Author: Andriy Redko <[email protected]> Date: Tue Mar 8 11:30:48 2022 -0500 Update the BWC versions (post 1.x backport) (opensearch-project#2390) Signed-off-by: Andriy Redko <[email protected]> commit 919d180 Author: Suraj Singh <[email protected]> Date: Mon Mar 7 12:43:05 2022 -0800 Remove type end-points from count action (opensearch-project#2379) Signed-off-by: Suraj Singh <[email protected]> commit 1f0361a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Mar 7 10:28:17 2022 -0800 Bump asm-commons from 5.0.4 to 9.2 in /modules/lang-expression (opensearch-project#2385) * Bump asm-commons from 5.0.4 to 9.2 in /modules/lang-expression Bumps asm-commons from 5.0.4 to 9.2. --- updated-dependencies: - dependency-name: org.ow2.asm:asm-commons dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> commit 09e16e3 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Mar 7 13:08:07 2022 -0500 Bump guava from 30.1.1-jre to 31.1-jre in /plugins/repository-azure (opensearch-project#2382) * Bump guava from 30.1.1-jre to 31.1-jre in /plugins/repository-azure Bumps [guava](https://github.com/google/guava) from 30.1.1-jre to 31.1-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> commit e1fd4b7 Author: Subhobrata Dey <[email protected]> Date: Mon Mar 7 08:51:49 2022 -0800 Add valuesField in PercentilesAggregationBuilder streamInput constructor (opensearch-project#2308) Signed-off-by: Subhobrata Dey <[email protected]> commit 4395ed5 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Mar 7 11:48:38 2022 -0500 Bump guava in /distribution/tools/upgrade-cli (opensearch-project#2383) Bumps [guava](https://github.com/google/guava) from 31.0.1-jre to 31.1-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 72c5d81 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Mar 7 11:48:18 2022 -0500 Bump guava in /distribution/tools/keystore-cli (opensearch-project#2384) Bumps [guava](https://github.com/google/guava) from 31.0.1-jre to 31.1-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 75e837d Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Mar 7 11:48:00 2022 -0500 Bump guava from 31.0.1-jre to 31.1-jre in /distribution/tools/plugin-cli (opensearch-project#2387) Bumps [guava](https://github.com/google/guava) from 31.0.1-jre to 31.1-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 3e9031f Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Mar 7 11:47:37 2022 -0500 Bump gradle-extra-configurations-plugin from 3.0.3 to 7.0.0 in /buildSrc (opensearch-project#2386) Bumps [gradle-extra-configurations-plugin](https://github.com/nebula-plugins/gradle-extra-configurations-plugin) from 3.0.3 to 7.0.0. - [Release notes](https://github.com/nebula-plugins/gradle-extra-configurations-plugin/releases) - [Changelog](https://github.com/nebula-plugins/gradle-extra-configurations-plugin/blob/main/CHANGELOG.md) - [Commits](nebula-plugins/gradle-extra-configurations-plugin@v3.0.3...v7.0.0) --- updated-dependencies: - dependency-name: com.netflix.nebula:gradle-extra-configurations-plugin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 9224537 Author: Owais Kazi <[email protected]> Date: Fri Mar 4 16:58:13 2022 -0800 Updated the url for docker distribution (opensearch-project#2325) Signed-off-by: Owais Kazi <[email protected]> commit d5e58a2 Author: Suraj Singh <[email protected]> Date: Fri Mar 4 16:40:47 2022 -0800 [Remove] Type mappings from GeoShapeQueryBuilder (opensearch-project#2322) * Remove type end-points from GeoShapeBuilder Signed-off-by: Suraj Singh <[email protected]> * Fix integration test failures Signed-off-by: Suraj Singh <[email protected]> commit be64af2 Author: aponb <[email protected]> Date: Sat Mar 5 01:34:09 2022 +0100 Replace exclusionary words whitelist and blacklist in the places that won't impact backwards compatibility (opensearch-project#2178) * Replace the exclusionary word whitelist with allowlist, and blacklist with denylist, in code commet and internal variable/method/class/package name. Signed-off-by: Andreas <[email protected]> commit ae52008 Author: Andriy Redko <[email protected]> Date: Fri Mar 4 17:44:52 2022 -0500 Fixing the --release flag usage for javac (opensearch-project#2343) (opensearch-project#2352) * Fixing the --release flag usage for javac (opensearch-project#2343) * Fixing the --release flag usage for javac Signed-off-by: Andriy Redko <[email protected]> * Fixing the --html5 flag usage for javadoc Signed-off-by: Andriy Redko <[email protected]> * Fix java-version-checker source/target compatibility settings (opensearch-project#2354) Signed-off-by: Andriy Redko <[email protected]> commit 0cc2c9b Author: Nick Knize <[email protected]> Date: Fri Mar 4 13:30:43 2022 -0600 [Remove] types from PutMappingRequest (opensearch-project#2335) Remove type support from putMappingRequest, dependencies, and all tests. Signed-off-by: Nicholas Walter Knize <[email protected]> commit 729bc43 Author: Nick Knize <[email protected]> Date: Fri Mar 4 10:52:24 2022 -0600 [Test-Failure] Mute TranslogPolicyIT (opensearch-project#2342) This test is slated for removal as it only applies to ancient indexes (Legacy 6.x). Muting test so bwc tests are consistent and no longer angry. Signed-off-by: Nicholas Walter Knize <[email protected]> commit 5f90227 Author: Andriy Redko <[email protected]> Date: Fri Mar 4 11:12:27 2022 -0500 Add '_name' field support to score functions and provide it back in explanation response (opensearch-project#2244) * Add '_name' field support to score functions and provide it back in explanation response Signed-off-by: Andriy Redko <[email protected]> * Address code review comments Signed-off-by: Andriy Redko <[email protected]> commit ae14259 Author: Daniel Doubrovkine (dB.) <[email protected]> Date: Thu Mar 3 15:34:53 2022 -0500 Restore Java 8 compatibility for build tools. (opensearch-project#2300) (opensearch-project#2321) * Restore Java 8 compatibility for build tools. Signed-off-by: dblock <[email protected]> * Make source code compatible with Java 8. Signed-off-by: dblock <[email protected]> commit cb57b92 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Mar 3 14:23:47 2022 -0500 Bump log4j-core in /buildSrc/src/testKit/thirdPartyAudit/sample_jars (opensearch-project#2281) Bumps log4j-core from 2.17.1 to 2.17.2. --- updated-dependencies: - dependency-name: org.apache.logging.log4j:log4j-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit cdb42ad Author: Vacha Shah <[email protected]> Date: Thu Mar 3 10:39:27 2022 -0800 Remove Github DCO action since DCO runs via Github App now (opensearch-project#2317) Signed-off-by: Vacha Shah <[email protected]> commit f13b951 Author: Andrey Pleskach <[email protected]> Date: Wed Mar 2 23:36:09 2022 +0100 Add support of SOCKS proxies for S3 repository (opensearch-project#2160) Signed-off-by: Andrey Pleskach <[email protected]> commit 3d5aff4 Author: Suraj Singh <[email protected]> Date: Wed Mar 2 13:21:00 2022 -0800 Remove type end-points from search and related APIs (opensearch-project#2263) Signed-off-by: Suraj Singh <[email protected]> commit 897f4e7 Author: Nick Knize <[email protected]> Date: Wed Mar 2 13:44:04 2022 -0600 [Remove] deprecated getMapping API from IndicesClient (opensearch-project#2262) Removes the deprecated types based get, getMapping, getAsync, and getMappingAsync methods from IndicesClient. It also removes extra nesting of mappings belong the deprecated type named object and removes the types based methods from the affected request classes. Signed-off-by: Nicholas Walter Knize <[email protected]> commit 4b89410 Author: Breno Faria <[email protected]> Date: Wed Mar 2 19:52:38 2022 +0100 Reintroduce negative epoch_millis opensearch-project#1991 (opensearch-project#2232) * Reintroduce negative epoch_millis opensearch-project#1991 Fixes a regression introduced with Elasticsearch 7 regarding the date field type that removed support for negative timestamps with sub-second granularity. Thanks to Ryan Kophs (https://github.com/rkophs) for allowing me to use his previous work. Signed-off-by: Breno Faria <[email protected]> * applying spotless fix Signed-off-by: Breno Faria <[email protected]> * more conservative implementation of isSupportedBy Signed-off-by: Breno Faria <[email protected]> * adding braces to control flow statement Signed-off-by: Breno Faria <[email protected]> * spotless fix... Signed-off-by: Breno Faria <[email protected]> Co-authored-by: Breno Faria <[email protected]> commit 9e225dc Author: Peng Huo <[email protected]> Date: Wed Mar 2 10:34:02 2022 -0800 Fix flaky test case - string profiler via global ordinals (opensearch-project#2226) forcemerge to one segment before executing aggregation query. Signed-off-by: Peng Huo <[email protected]> commit c8a7606 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 28 12:18:28 2022 -0800 Bump commons-math3 from 3.2 to 3.6.1 in /benchmarks (opensearch-project#2282) Bumps commons-math3 from 3.2 to 3.6.1. --- updated-dependencies: - dependency-name: org.apache.commons:commons-math3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 1b8181c Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 28 12:17:16 2022 -0800 Bump gson from 2.8.9 to 2.9.0 in /plugins/repository-hdfs (opensearch-project#2279) * Bump gson from 2.8.9 to 2.9.0 in /plugins/repository-hdfs Bumps [gson](https://github.com/google/gson) from 2.8.9 to 2.9.0. - [Release notes](https://github.com/google/gson/releases) - [Changelog](https://github.com/google/gson/blob/master/CHANGELOG.md) - [Commits](google/gson@gson-parent-2.8.9...gson-parent-2.9.0) --- updated-dependencies: - dependency-name: com.google.code.gson:gson dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> commit 0df9845 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 28 12:16:56 2022 -0800 Bump morfologik-fsa from 2.1.1 to 2.1.8 in /plugins/analysis-ukrainian (opensearch-project#2278) * Bump morfologik-fsa from 2.1.1 to 2.1.8 in /plugins/analysis-ukrainian Bumps [morfologik-fsa](https://github.com/morfologik/morfologik-stemming) from 2.1.1 to 2.1.8. - [Release notes](https://github.com/morfologik/morfologik-stemming/releases) - [Changelog](https://github.com/morfologik/morfologik-stemming/blob/master/CHANGES.txt) - [Commits](morfologik/morfologik-stemming@2.1.1...2.1.8) --- updated-dependencies: - dependency-name: org.carrot2:morfologik-fsa dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> commit 9780fc6 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 28 12:16:34 2022 -0800 Bump bc-fips from 1.0.2.1 to 1.0.2.3 in /distribution/tools/plugin-cli (opensearch-project#2276) * Bump bc-fips from 1.0.2.1 to 1.0.2.3 in /distribution/tools/plugin-cli Bumps bc-fips from 1.0.2.1 to 1.0.2.3. --- updated-dependencies: - dependency-name: org.bouncycastle:bc-fips dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> commit 4ef30f4 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 28 10:41:46 2022 -0800 Bump azure-storage-common from 12.14.0 to 12.14.3 in /plugins/repository-azure (opensearch-project#2274) * Bump azure-storage-common in /plugins/repository-azure Bumps [azure-storage-common](https://github.com/Azure/azure-sdk-for-java) from 12.14.0 to 12.14.3. - [Release notes](https://github.com/Azure/azure-sdk-for-java/releases) - [Commits](Azure/azure-sdk-for-java@azure-storage-blob_12.14.0...azure-storage-blob_12.14.3) --- updated-dependencies: - dependency-name: com.azure:azure-storage-common dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> commit 5d0b015 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 28 10:41:33 2022 -0800 Bump jimfs from 1.1 to 1.2 in /distribution/tools/keystore-cli (opensearch-project#2272) Bumps [jimfs](https://github.com/google/jimfs) from 1.1 to 1.2. - [Release notes](https://github.com/google/jimfs/releases) - [Commits](google/jimfs@v1.1...v1.2) --- updated-dependencies: - dependency-name: com.google.jimfs:jimfs dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit f6264a9 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 28 10:41:18 2022 -0800 Bump spock-core from 2.0-groovy-3.0 to 2.1-groovy-3.0 in /buildSrc (opensearch-project#2270) Bumps spock-core from 2.0-groovy-3.0 to 2.1-groovy-3.0. --- updated-dependencies: - dependency-name: org.spockframework:spock-core dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 21f11ec Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 28 10:40:51 2022 -0800 Bump asm-tree from 5.0.4 to 9.2 in /modules/lang-expression (opensearch-project#2269) * Bump asm-tree from 5.0.4 to 9.2 in /modules/lang-expression Bumps asm-tree from 5.0.4 to 9.2. --- updated-dependencies: - dependency-name: org.ow2.asm:asm-tree dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> commit 223d0b2 Author: Suraj Singh <[email protected]> Date: Fri Feb 25 13:00:25 2022 -0800 Remove type end-points from no-op bulk and search action (opensearch-project#2261) Signed-off-by: Suraj Singh <[email protected]> commit 0bd7850 Author: Nick Knize <[email protected]> Date: Fri Feb 25 13:35:48 2022 -0600 [Remove] remaining type usage in Client and AbstractClient (opensearch-project#2258) Removes type parameter from remaining prepareIndex in Client and AbstractClient. Signed-off-by: Nicholas Walter Knize <[email protected]> commit 3a4c2f6 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Feb 25 10:40:11 2022 -0800 Bump jimfs from 1.1 to 1.2 in /qa/evil-tests (opensearch-project#2130) * Bump jimfs from 1.1 to 1.2 in /qa/evil-tests Bumps [jimfs](https://github.com/google/jimfs) from 1.1 to 1.2. - [Release notes](https://github.com/google/jimfs/releases) - [Commits](google/jimfs@v1.1...v1.2) --- updated-dependencies: - dependency-name: com.google.jimfs:jimfs dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Fixing failing precommit and check Signed-off-by: Vacha Shah <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vacha Shah <[email protected]> commit 5b0da85 Author: Suraj Singh <[email protected]> Date: Fri Feb 25 10:18:41 2022 -0800 Remove type from validate query API (opensearch-project#2255) * Remove type mapping from RestValidateAction Signed-off-by: Suraj Singh <[email protected]> * Spotless check apply Signed-off-by: Suraj Singh <[email protected]> * Include suggested review comment Signed-off-by: Suraj Singh <[email protected]> commit 494c7bc Author: Rishikesh Pasham <[email protected]> Date: Fri Feb 25 03:39:43 2022 +0000 Revert "Override Default Distribution Download Url with Custom Distribution Url When User Passes a Url" (opensearch-project#2256) * Override default Distribution Download URL with custom Distribution URL Signed-off-by: Rishikesh1159 <[email protected]> * Accidently made commit to main branch, this revives it.Override default Distribution Download URL with custom Distribution URL Signed-off-by: Rishikesh1159 <[email protected]> * Revert Override Default Distribution Download Url with Custom Distribution Url When User Passes a Url Signed-off-by: Rishikesh1159 <[email protected]> commit 8b48207 Author: Nick Knize <[email protected]> Date: Thu Feb 24 21:20:03 2022 -0600 [Remove] Type from Client.prepare(Index,Delete,Update) (opensearch-project#2253) Removes the type parameter from Client.prepare(Index,Delete,Update) and everywhere it's used throughout the codebase except for prepareIndex(index, type, id) which is removed in a follow up. Signed-off-by: Nicholas Walter Knize <[email protected]> Merge branch 'main' into feature/segment-replication Signed-off-by: Kartik Ganesh <[email protected]>

nknize added v2.0.0 Version 2.0.0 >breaking Identifies a breaking change. Indexing & Search labels Mar 4, 2022

nknize requested a review from a team as a code owner March 4, 2022 00:27

dreamer-89 mentioned this pull request Mar 4, 2022

[BUG] ./gradlew ':qa:full-cluster-restart:v1.3.0#oldClusterTest' fails #2334

Closed

[Remove] types from PutMappingRequest

38f2f29

Remove type support from putMappingRequest, dependencies, and all tests. Signed-off-by: Nicholas Walter Knize <[email protected]>

nknize added 7 commits March 4, 2022 10:53

fix build failure w/ logger

17f2db5

Signed-off-by: Nicholas Walter Knize <[email protected]>

remove deprecated putMapping methods

de6e7e0

Signed-off-by: Nicholas Walter Knize <[email protected]>

fix failing tests

7266564

Signed-off-by: Nicholas Walter Knize <[email protected]>

fix SizeMappingIT

2ceca1e

Signed-off-by: Nicholas Walter Knize <[email protected]>

fix remaining SizeMappingIT

44262e0

Signed-off-by: Nicholas Walter Knize <[email protected]>

More test failure fixes by removing types other than _doc

6441ea6

Signed-off-by: Nicholas Walter Knize <[email protected]>

remove type from PutMappingRequest.buildFromSimplifiedDef

6cf60d9

Signed-off-by: Nicholas Walter Knize <[email protected]>

nknize force-pushed the remove/typesFromPutMapping branch from 012ad3f to 6cf60d9 Compare March 4, 2022 16:53

nknize mentioned this pull request Mar 4, 2022

[CI] o.o.index.ShardIndexingPressureSettingsIT.testShardIndexingPressureEnforcedEnabledDisabledSetting #2348

Closed

remove types from more IT tests

e7b59ab

Signed-off-by: Nicholas Walter Knize <[email protected]>

dreamer-89 approved these changes Mar 4, 2022

View reviewed changes

nknize merged commit 0cc2c9b into opensearch-project:main Mar 4, 2022

dreamer-89 mentioned this pull request Mar 4, 2022

[Meta] Remove mapping types #1940

Closed

67 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Remove] types from PutMappingRequest #2335

[Remove] types from PutMappingRequest #2335

nknize commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

dreamer-89 commented Mar 4, 2022

dreamer-89 commented Mar 4, 2022

nknize commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

dreamer-89 commented Mar 4, 2022 •

edited

Loading

nknize commented Mar 4, 2022

dreamer-89 commented Mar 4, 2022

VachaShah commented Mar 4, 2022 •

edited

Loading

dblock commented Mar 4, 2022

reta commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

nknize commented Mar 4, 2022

nknize commented Mar 4, 2022

nknize commented Mar 4, 2022

reta commented Mar 4, 2022

nknize commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

dreamer-89 left a comment

dreamer-89 Mar 4, 2022 •

edited

Loading

nknize Mar 4, 2022

[Remove] types from PutMappingRequest #2335

[Remove] types from PutMappingRequest #2335

Conversation

nknize commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

dreamer-89 commented Mar 4, 2022

dreamer-89 commented Mar 4, 2022

nknize commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

dreamer-89 commented Mar 4, 2022 • edited Loading

nknize commented Mar 4, 2022

dreamer-89 commented Mar 4, 2022

VachaShah commented Mar 4, 2022 • edited Loading

dblock commented Mar 4, 2022

reta commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

nknize commented Mar 4, 2022

nknize commented Mar 4, 2022

nknize commented Mar 4, 2022

reta commented Mar 4, 2022

nknize commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

dreamer-89 left a comment

Choose a reason for hiding this comment

dreamer-89 Mar 4, 2022 • edited Loading

Choose a reason for hiding this comment

nknize Mar 4, 2022

Choose a reason for hiding this comment

dreamer-89 commented Mar 4, 2022 •

edited

Loading

VachaShah commented Mar 4, 2022 •

edited

Loading

dreamer-89 Mar 4, 2022 •

edited

Loading