Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Javadocs] add remaining internal classes and reenable missingJavadoc on server (#3296) #3318

Merged
merged 2 commits into from
May 13, 2022
Merged

[Backport 2.x] [Javadocs] add remaining internal classes and reenable missingJavadoc on server (#3296) #3318

merged 2 commits into from
May 13, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 3aef125 from #3296

@opensearch-trigger-bot opensearch-trigger-bot bot requested review from a team and reta as code owners May 13, 2022 17:49
@nknize
Copy link
Collaborator

nknize commented May 13, 2022

Will fail until all javadoc 2.x backport PRs are merged.

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 487b1660396a06c6eb81025e8ee4e269809247a9
Log 5306

Reports 5306

@nknize
[Javadocs] add remaining internal classes and reenable missingJavadoc…
ce41a5b 
… on server (#3296)

Adds the remaining javadocs to internal classes and reenables the missingJavadoc
gradle task on the server module. From here forward if class level javadocs are
missing in the server module, gradle check will fail!

Signed-off-by: Nicholas Walter Knize <[email protected]>
(cherry picked from commit 3aef125)
@nknize
Add docs that are not within the main branch
119d9c4 
Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize nknize force-pushed the backport/backport-3296-to-2.x branch from 487b166 to 119d9c4 Compare May 13, 2022 18:50
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 119d9c4
Log 5309

Reports 5309

@nknize nknize mentioned this pull request May 13, 2022
Open
@nknize
Copy link
Collaborator

nknize commented May 13, 2022

New failure that is unrelated to this PR!!! Opened #3321

./gradlew ':server:test' --tests "org.opensearch.index.query.IntervalQueryBuilderTests.testMustRewrite" -Dtests.seed=A6236EB12532F6E5 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ms-MY -Dtests.timezone=America/Rosario -Druntime.java=17

org.opensearch.index.query.IntervalQueryBuilderTests > testMustRewrite FAILED
    java.lang.IllegalArgumentException: Too many disjunctions to expand
        at __randomizedtesting.SeedInfo.seed([A6236EB12532F6E5:12CC1D8C5D65F065]:0)
        at org.apache.lucene.queries.intervals.Disjunctions.pullUp(Disjunctions.java:45)
        at org.apache.lucene.queries.intervals.OrderedIntervalsSource.pullUpDisjunctions(OrderedIntervalsSource.java:91)
        at org.apache.lucene.queries.intervals.FilteredIntervalsSource.maxGaps(FilteredIntervalsSource.java:33)
        at org.apache.lucene.queries.intervals.Intervals.maxgaps(Intervals.java:302)
        at org.opensearch.index.query.IntervalBuilder.combineSources(IntervalBuilder.java:173)
        at org.opensearch.index.query.IntervalsSourceProvider$Combine.getSource(IntervalsSourceProvider.java:468)
...

Going to refire ad we'll address the issue separately

@nknize
Copy link
Collaborator

nknize commented May 13, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 119d9c4
Log 5314

Reports 5314

@nknize
Copy link
Collaborator

nknize commented May 13, 2022

#1703 again

@nknize
Copy link
Collaborator

nknize commented May 13, 2022

start gradle check

@nknize nknize changed the title [Backport 2.x] [Javadocs] add remaining internal classes and reenable missingJavadoc on server [Backport 2.x] [Javadocs] add remaining internal classes and reenable missingJavadoc on server (#3296) May 13, 2022
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 119d9c4
Log 5321

Reports 5321

@nknize nknize merged commit c79afbe into 2.x May 13, 2022
@github-actions github-actions bot deleted the backport/backport-3296-to-2.x branch May 13, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nknize nknize nknize approved these changes

@reta reta reta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nknize @opensearch-ci-bot @reta