[2.x] Deprecate classes in org.opensearch.action.support.master (#3593) #3609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-project#3593) Signed-off-by: Tianli Feng <[email protected]>
tlfeng
changed the title
tlfeng
added
backport
tlfeng
added
the
enhancement
xuezhou25
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport PR #3593 / commit 223d472 to
2.xbranchTo support inclusive language, the master terminology is going to be replaced by cluster manager in the code base.
In PR #3597, the package
org.opensearch.action.support.masterhas be renamed toorg.opensearch.action.support.clustermanager, and the classes with "master" name are renamed as well.This PR adds the old package and classes back to keep the backwards compatibility and marks them as deprecated.
Apply 3 changes to the original classes in the package org.opensearch.action.support.master.
1 Remove all the methods in the classes.
2 Make them extend the corresponding classes with "cluster manager" name.
3 Add the same constructors with the corresponding "cluster manager" classes.
Issues Resolved
The second step for issue #3542 on
2.xbranch.It will be resolved by a following PR to rename and deprecate the public methods and variables in the package.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.