Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Deprecate and Rename abstract methods from 'Master' terminology to 'ClusterManager'. #4048

Merged
merged 1 commit into from
Jul 30, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Jul 30, 2022

Backport 2a1b239 from #4032

This PR deprecates and renames the following abstract methods:

In class TransportMasterNodeAction -
abstract void masterOperation(Request request, ClusterState state, ActionListener listener)

In class TransportClusterInfoAction -
abstract void doMasterOperation(Request request, String[] concreteIndices, ClusterState state, ActionListener listener)

In class TestCluster:
public abstract int numDataAndMasterNodes();

and the following concrete methods:

In class TransportMasterNodeAction -
void masterOperation(Task task, Request request, ClusterState state, ActionListener<Response> listener)

In class TransportClusterInfoAction -
void masterOperation(final Request request, final ClusterState state, final ActionListener<Response> listener)

…lusterManager'. (#4032)

This commit deprecates and renames the following abstract methods:
```
In class TransportMasterNodeAction -
abstract void masterOperation(Request request, ClusterState state, ActionListener listener)

In class TransportClusterInfoAction -
abstract void doMasterOperation(Request request, String[] concreteIndices, ClusterState state, ActionListener listener)

In class TestCluster:
public abstract int numDataAndMasterNodes();
```

and the following concrete methods:
```
In class TransportMasterNodeAction -
void masterOperation(Task task, Request request, ClusterState state, ActionListener<Response> listener)

In class TransportClusterInfoAction -
void masterOperation(final Request request, final ClusterState state, final ActionListener<Response> listener)
```

Signed-off-by: Rishikesh1159 <[email protected]>
(cherry picked from commit 2a1b239)
@opensearch-trigger-bot opensearch-trigger-bot bot requested review from a team and reta as code owners July 30, 2022 00:24
@tlfeng tlfeng added enhancement Enhancement or improvement to existing feature or request backport PRs or issues specific to backporting features or enhancments deprecate v2.2.0 labels Jul 30, 2022
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@tlfeng tlfeng merged commit a16be07 into 2.x Jul 30, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4048 (5b01a97) into 2.x (053cf55) will increase coverage by 0.06%.
The diff coverage is 20.00%.

@@             Coverage Diff              @@
##                2.x    #4048      +/-   ##
============================================
+ Coverage     70.49%   70.56%   +0.06%     
- Complexity    56511    56542      +31     
============================================
  Files          4532     4532              
  Lines        272114   272126      +12     
  Branches      40000    40000              
============================================
+ Hits         191832   192015     +183     
+ Misses        64204    63989     -215     
- Partials      16078    16122      +44     
Impacted Files Coverage Δ
...ation/TransportClusterAllocationExplainAction.java 52.77% <ø> (-6.95%) ⬇️
...tion/TransportAddVotingConfigExclusionsAction.java 83.33% <ø> (-4.17%) ⬇️
...on/TransportClearVotingConfigExclusionsAction.java 83.72% <ø> (-4.66%) ⬇️
...n/cluster/health/TransportClusterHealthAction.java 47.75% <ø> (ø)
...ries/cleanup/TransportCleanupRepositoryAction.java 56.86% <ø> (ø)
...tories/delete/TransportDeleteRepositoryAction.java 100.00% <ø> (ø)
...positories/get/TransportGetRepositoriesAction.java 9.37% <ø> (ø)
...repositories/put/TransportPutRepositoryAction.java 100.00% <ø> (ø)
...tories/verify/TransportVerifyRepositoryAction.java 33.33% <ø> (ø)
...cluster/reroute/TransportClusterRerouteAction.java 44.00% <ø> (+1.33%) ⬆️
... and 529 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@github-actions github-actions bot deleted the backport/backport-4032-to-2.x branch July 30, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments deprecate enhancement Enhancement or improvement to existing feature or request v2.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants