[Remote Store] Change remote_store setting validation message to make it more clear

[sachinpkale]

Signed-off-by: Sachin Kale [email protected]

Description

• Currently, if we try to enable index.remote_store.enabled without setting replication type to SEGMENT, we get following error:

{
  "error" : {
    "root_cause" : [
      {
        "type" : "illegal_argument_exception",
        "reason" : "Settings index.remote_store.enabled cannot be enabled when index.replication.type is set to DOCUMENT"
      }
    ],
    "type" : "illegal_argument_exception",
    "reason" : "Settings index.remote_store.enabled cannot be enabled when index.replication.type is set to DOCUMENT"
  },
  "status" : 400
}

• But this does not make the dependency of segment replication clear. With this change, we are changing the error message to:

{
  "error" : {
    "root_cause" : [
      {
        "type" : "illegal_argument_exception",
        "reason" : "To enable index.remote_store.enabled, index.replication.type should be set to SEGMENT"
      }
    ],
    "type" : "illegal_argument_exception",
    "reason" : "To enable index.remote_store.enabled, index.replication.type should be set to SEGMENT"
  },
  "status" : 400
}

Issues Resolved

• [Remote Store] Fix message on enabling remote store without segment replication #4201

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/1690/
• CommitID: d6dea08

[BhumikaSaini-Amazon]

Thanks for adding this!
Please could you help update the unit tests as well for this change?

[sachinpkale]

Please could you help update the unit tests as well for this change?

Forgot to update UTs. Thanks @BhumikaSaini-Amazon

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/1693/
• CommitID: 13999e0

[BhumikaSaini-Amazon]

Looks good to me 👍
Please link the respective Issue to this PR and strike off the PR checklist items
Thanks!

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/1694/
• CommitID: 7cd1001

[sachinpkale]

Looks good to me 👍 Please link the respective Issue to this PR and strike off the PR checklist items Thanks!

@BhumikaSaini-Amazon Added issue link and updated PR checklist.