Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Segment Replication] - Update replicas to commit SegmentInfos instead of relying on segments_N from primary shards. #4402

Merged
merged 3 commits into from
Sep 7, 2022
Merged

[Segment Replication] - Update replicas to commit SegmentInfos instead of relying on segments_N from primary shards. #4402

merged 3 commits into from
Sep 7, 2022

Commits on Sep 7, 2022

  1. Segment Replication - Update replicas to commit SegmentInfos instead … 

    …of relying on segments_N from primary shards.

This change updates replicas to commit SegmentInfos before the shard is closed, on receiving a new commit point from a primary, and when a new primary is detected. This change also makes the public commitSegmentInfos on NRTEngine obsolete, refactoring IndexShard to simply call reset on the engine.

Signed-off-by: Marc Handalian <[email protected]>
    @mch2
    mch2 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    2c276c4 View commit details
    Browse the repository at this point in the history

  2. Remove noise & extra log statement. 

    Signed-off-by: Marc Handalian <[email protected]>
    @mch2
    mch2 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    d8f2cab View commit details
    Browse the repository at this point in the history

  3. PR feedback. 

    Signed-off-by: Marc Handalian <[email protected]>
    @mch2
    mch2 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    bb89929 View commit details
    Browse the repository at this point in the history