Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remove] LegacyESVersion.V_7_10_* constants #5018

Merged
merged 4 commits into from
Nov 1, 2022

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Nov 1, 2022

Removes all usages of LegacyESVersion.V_7_10_ version constants along with ancient API logic.

closes #2747

Removes all usages of LegacyESVersion.V_7_10_ version constants along with
ancient API logic.

Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize nknize added non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues >upgrade Label used when upgrading library dependencies (e.g., Lucene) v3.0.0 Issues and PRs related to version 3.0.0 labels Nov 1, 2022
@nknize nknize requested review from a team and reta as code owners November 1, 2022 15:26
Signed-off-by: Nicholas Walter Knize <[email protected]>
@@ -326,11 +325,7 @@ public DiscoveryNode(StreamInput in) throws IOException {
final String roleName = in.readString();
final String roleNameAbbreviation = in.readString();
final boolean canContainData;
Copy link
Collaborator

@reta reta Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, final boolean canContainData = in.readBoolean();

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Nicholas Walter Knize <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Nicholas Walter Knize <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

Gradle Check (Jenkins) Run Completed with:

@nknize nknize merged commit f0aed87 into opensearch-project:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues >upgrade Label used when upgrading library dependencies (e.g., Lucene) v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all LegacyESVersion.V_7x constants
2 participants