Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version check for 2.x release for awareness attribute decommission #5034

Merged

Conversation

imRishN
Copy link
Member

@imRishN imRishN commented Nov 2, 2022

Signed-off-by: Rishab Nahata [email protected]

Description

Fixes the version check for decommission metadata and exceptions related to decommission
Backport PR for decommission - #4970

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rishab Nahata <[email protected]>
@imRishN imRishN requested review from a team and reta as code owners November 2, 2022 07:19
@imRishN imRishN changed the title Fix version for 2.x release Fix version check for 2.x release for awareness attribute decommission Nov 2, 2022
Signed-off-by: Rishab Nahata <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

Merging #5034 (8206ade) into main (fab4336) will decrease coverage by 0.00%.
The diff coverage is 64.28%.

@@             Coverage Diff              @@
##               main    #5034      +/-   ##
============================================
- Coverage     70.84%   70.83%   -0.01%     
- Complexity    57867    57937      +70     
============================================
  Files          4692     4695       +3     
  Lines        276650   276952     +302     
  Branches      40155    40170      +15     
============================================
+ Hits         196002   196189     +187     
- Misses        64500    64690     +190     
+ Partials      16148    16073      -75     
Impacted Files Coverage Δ
...java/org/opensearch/upgrade/ValidateInputTask.java 84.61% <0.00%> (ø)
.../src/main/java/org/opensearch/LegacyESVersion.java 59.34% <ø> (-2.37%) ⬇️
...ensearch/action/search/SearchTransportService.java 83.75% <ø> (-3.25%) ⬇️
...va/org/opensearch/action/update/UpdateRequest.java 45.48% <0.00%> (+1.03%) ⬆️
.../cluster/metadata/IndexNameExpressionResolver.java 83.79% <ø> (-0.03%) ⬇️
...va/org/opensearch/cluster/node/DiscoveryNodes.java 90.41% <ø> (+0.51%) ⬆️
.../opensearch/index/stats/IndexingPressureStats.java 33.78% <0.00%> (+1.31%) ⬆️
...rc/main/java/org/opensearch/monitor/fs/FsInfo.java 75.00% <ø> (+1.92%) ⬆️
...ggregations/metrics/TopHitsAggregationBuilder.java 64.41% <0.00%> (-0.19%) ⬇️
.../java/org/opensearch/test/InternalTestCluster.java 60.76% <7.14%> (-0.88%) ⬇️
... and 514 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

Gradle Check (Jenkins) Run Completed with:

@Bukhtawar Bukhtawar merged commit 81ef331 into opensearch-project:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants