Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused classes #5258

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Remove unused classes #5258

merged 1 commit into from
Nov 15, 2022

Conversation

adnapibar
Copy link
Contributor

Description

These internal classes are not used anymore and can be safely removed.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rabi Panda [email protected]

Signed-off-by: Rabi Panda <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@adnapibar
Copy link
Contributor Author

#4881

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@kotwanikunal
Copy link
Member

I can see that some of the classes are public and are not marked as opensearch.internal. Should we call this out within the breaking changes?

@adnapibar
Copy link
Contributor Author

I can see that some of the classes are public and are not marked as opensearch.internal. Should we call this out within the breaking changes?

Sure, which one is not marked as opensearch.internal ?

@kotwanikunal
Copy link
Member

I can see that some of the classes are public and are not marked as opensearch.internal. Should we call this out within the breaking changes?

Sure, which one is not marked as opensearch.internal ?

My bad. I was looking at the header docs instead of class documentation.

@dblock dblock merged commit 2a03ddb into opensearch-project:main Nov 15, 2022
@adnapibar adnapibar deleted the remove-unused-classes branch November 18, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants