Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] OperationRoutingTests.testWeightedOperationRoutingWeightUndefinedForOneZone failure #5289

Merged
merged 4 commits into from
Nov 18, 2022

Conversation

anshu1106
Copy link
Contributor

Signed-off-by: Anshu Agarwal [email protected]

Description

This PR fixes flaky test introduced with #4241

Issues Resolved

#4881

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Anshu Agarwal <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE ❌
  • FAILURES:

@adnapibar
Copy link
Contributor

@anshu1106 can you rebase your PR onto main? The test failure in CI was fixed recently.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #5289 (83419ae) into main (7aa615f) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #5289      +/-   ##
============================================
- Coverage     71.02%   70.91%   -0.11%     
+ Complexity    58161    58105      -56     
============================================
  Files          4704     4704              
  Lines        277401   277401              
  Branches      40166    40166              
============================================
- Hits         197025   196730     -295     
- Misses        64204    64514     +310     
+ Partials      16172    16157      -15     
Impacted Files Coverage Δ
...adonly/AddIndexBlockClusterStateUpdateRequest.java 0.00% <0.00%> (-75.00%) ⬇️
...readonly/TransportVerifyShardIndexBlockAction.java 9.75% <0.00%> (-58.54%) ⬇️
...ava/org/opensearch/action/NoSuchNodeException.java 0.00% <0.00%> (-50.00%) ⬇️
...regations/metrics/AbstractHyperLogLogPlusPlus.java 51.72% <0.00%> (-44.83%) ⬇️
...indices/readonly/TransportAddIndexBlockAction.java 20.68% <0.00%> (-37.94%) ⬇️
...cluster/coordination/PublishClusterStateStats.java 33.33% <0.00%> (-37.51%) ⬇️
...ain/java/org/opensearch/search/sort/MinAndMax.java 63.15% <0.00%> (-36.85%) ⬇️
...nsearch/index/shard/IndexShardClosedException.java 66.66% <0.00%> (-33.34%) ⬇️
.../indices/readonly/AddIndexBlockRequestBuilder.java 0.00% <0.00%> (-33.34%) ⬇️
...ava/org/opensearch/threadpool/ThreadPoolStats.java 52.00% <0.00%> (-29.34%) ⬇️
... and 492 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Anshu Agarwal <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dblock dblock merged commit 2932d56 into opensearch-project:main Nov 18, 2022
@dblock dblock added the backport 2.x Backport to 2.x branch label Nov 18, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 18, 2022
…edForOneZone failure (#5289)

* Fix wrr flaky test

Signed-off-by: Anshu Agarwal <[email protected]>

* Add changelog

Signed-off-by: Anshu Agarwal <[email protected]>

* Remove changelog

Signed-off-by: Anshu Agarwal <[email protected]>

Signed-off-by: Anshu Agarwal <[email protected]>
Co-authored-by: Anshu Agarwal <[email protected]>
(cherry picked from commit 2932d56)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
adnapibar pushed a commit that referenced this pull request Nov 19, 2022
…edForOneZone failure (#5289) (#5309)


Signed-off-by: Anshu Agarwal <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants