-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] OperationRoutingTests.testWeightedOperationRoutingWeightUndefinedForOneZone failure #5289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anshu Agarwal <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
@anshu1106 can you rebase your PR onto main? The test failure in CI was fixed recently. |
Signed-off-by: Anshu Agarwal <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #5289 +/- ##
============================================
- Coverage 71.02% 70.91% -0.11%
+ Complexity 58161 58105 -56
============================================
Files 4704 4704
Lines 277401 277401
Branches 40166 40166
============================================
- Hits 197025 196730 -295
- Misses 64204 64514 +310
+ Partials 16172 16157 -15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
adnapibar
reviewed
Nov 18, 2022
Signed-off-by: Anshu Agarwal <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
adnapibar
approved these changes
Nov 18, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 18, 2022
…edForOneZone failure (#5289) * Fix wrr flaky test Signed-off-by: Anshu Agarwal <[email protected]> * Add changelog Signed-off-by: Anshu Agarwal <[email protected]> * Remove changelog Signed-off-by: Anshu Agarwal <[email protected]> Signed-off-by: Anshu Agarwal <[email protected]> Co-authored-by: Anshu Agarwal <[email protected]> (cherry picked from commit 2932d56) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
adnapibar
pushed a commit
that referenced
this pull request
Nov 19, 2022
…edForOneZone failure (#5289) (#5309) Signed-off-by: Anshu Agarwal <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anshu Agarwal [email protected]
Description
This PR fixes flaky test introduced with #4241
Issues Resolved
#4881
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.