Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search backpressure cancellation at the coordinator level #5605

Merged
merged 49 commits into from
Feb 5, 2023
Merged

Add search backpressure cancellation at the coordinator level #5605

merged 49 commits into from
Feb 5, 2023

Commits on Dec 19, 2022

  1. Cancellation of in-flight search requests at coordinator level 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    1402ced View commit details
    Browse the repository at this point in the history

  2. Cancellation of in-flight search requests at coordinator level 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    9ccdae5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'searchbackpressure/search-task-cancellation' of github.… 

    …com:PritLadani/OpenSearch into searchbackpressure/search-task-cancellation
    @PritLadani
    PritLadani committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    253fc61 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Fixing test failures 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    5817770 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'opensearch-project:main' into searchbackpressure/search… 

    …-task-cancellation
    @PritLadani
    PritLadani authored Dec 20, 2022
    Configuration menu
    Copy the full SHA
    dee7efb View commit details
    Browse the repository at this point in the history

  3. java code formatting 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    1f188a3 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. Adding unit tests and integration tests 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    64c6ed0 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. Introducing separate thresholds for different task types 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    5b846a2 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. Adding java docs 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    4778162 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. Moving cancellation settings to task specific settings 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    5b0bf15 View commit details
    Browse the repository at this point in the history

  2. Moving cancellation settings to task specific settings 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    ac0688f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'searchbackpressure/search-task-cancellation' of github.… 

    …com:PritLadani/OpenSearch into searchbackpressure/search-task-cancellation
    @PritLadani
    PritLadani committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    663e4ee View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Separating SearchTaskStats and SearchShardTaskStats 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    53609a7 View commit details
    Browse the repository at this point in the history

  2. Cancellation of in-flight search requests at coordinator level 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    102cfd5 View commit details
    Browse the repository at this point in the history

  3. Fixing test failures 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    474be6c View commit details
    Browse the repository at this point in the history

  4. java code formatting 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    72c5d87 View commit details
    Browse the repository at this point in the history

  5. Adding unit tests and integration tests 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    0192d6c View commit details
    Browse the repository at this point in the history

  6. Introducing separate thresholds for different task types 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    b31b876 View commit details
    Browse the repository at this point in the history

  7. Adding java docs 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    6f75c23 View commit details
    Browse the repository at this point in the history

  8. Moving cancellation settings to task specific settings 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    2f299ce View commit details
    Browse the repository at this point in the history

  9. Separating SearchTaskStats and SearchShardTaskStats 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    339a746 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'searchbackpressure/search-task-cancellation' of github.… 

    …com:PritLadani/OpenSearch into searchbackpressure/search-task-cancellation
    @PritLadani
    PritLadani committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    b2c2062 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. Merge branch 'searchbackpressure/search-task-cancellation' of github.… 

    …com:PritLadani/OpenSearch into searchbackpressure/search-task-cancellation

Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    d2bcb88 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'searchbackpressure/search-task-cancellation' of github.… 

    …com:PritLadani/OpenSearch into searchbackpressure/search-task-cancellation
    @PritLadani
    PritLadani committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    bcc6483 View commit details
    Browse the repository at this point in the history

  3. Changing default values for SearchTaskSettings 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    7d52b52 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. Adding version checks for SearchTaskStats 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    5933c2d View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2023

  1. Avoiding heap usage cancellation in case of undefined maximum heap me… 

    …mory

Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    d933936 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into searchbackpressure/search-task-cancellation

    @PritLadani
    PritLadani committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    e80e79d View commit details
    Browse the repository at this point in the history

  3. Moving limiters in SearchBackpressureState 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    31f3f07 View commit details
    Browse the repository at this point in the history

  4. code formatting 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    26d19a0 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. Merge branch 'main' into searchbackpressure/search-task-cancellation

    @PritLadani
    PritLadani committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    156225a View commit details
    Browse the repository at this point in the history

  2. Adding TaskManager#cancelTaskAndDescendants for task cancellation 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    dd10073 View commit details
    Browse the repository at this point in the history

  3. Removing heap usage tracker if heap size is undefined 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    9e0fa78 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Merge branch 'main' into searchbackpressure/search-task-cancellation

    @PritLadani
    PritLadani committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    3ff7116 View commit details
    Browse the repository at this point in the history

  2. Extracting CancellationListener 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    1f17964 View commit details
    Browse the repository at this point in the history

  3. Extracting CancellationListener 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    7d06d91 View commit details
    Browse the repository at this point in the history

  4. Defining cancellation settings as volatile variables 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    950248d View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Separating SearchTaskStats and SearchShardTaskStats to avoid BWC issues 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    d9c113d View commit details
    Browse the repository at this point in the history

  2. Moving getTrackers to SearchBackpressureService 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    8e09787 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Updating UTs 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    0732c74 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'opensearch-project:main' into searchbackpressure/search… 

    …-task-cancellation
    @PritLadani
    PritLadani authored Feb 2, 2023
    Configuration menu
    Copy the full SHA
    97533cb View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. Re-adding deprecated settings to address BWC issues 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    4ee781c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'searchbackpressure/search-task-cancellation' of github.… 

    …com:PritLadani/OpenSearch into searchbackpressure/search-task-cancellation
    @PritLadani
    PritLadani committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    d28cda6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'opensearch-project:main' into searchbackpressure/search… 

    …-task-cancellation
    @PritLadani
    PritLadani authored Feb 3, 2023
    Configuration menu
    Copy the full SHA
    9cb6c6b View commit details
    Browse the repository at this point in the history

  4. Adding method to check if heap usage tracking is enabled 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    874cd97 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'searchbackpressure/search-task-cancellation' of github.… 

    …com:PritLadani/OpenSearch into searchbackpressure/search-task-cancellation
    @PritLadani
    PritLadani committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    e8df261 View commit details
    Browse the repository at this point in the history

  6. Isolating HEAP_SIZE_BYTES value 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    881bdee View commit details
    Browse the repository at this point in the history

  7. Moving changelog to unreleased 2.x section 

    Signed-off-by: PritLadani <[email protected]>
    @PritLadani
    PritLadani committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    5da5817 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2023

  1. Merge branch 'main' into searchbackpressure/search-task-cancellation

    @Bukhtawar
    Bukhtawar authored Feb 5, 2023
    Configuration menu
    Copy the full SHA
    bf19bf7 View commit details
    Browse the repository at this point in the history