Adding query fuzziness validation #5805

sejli · 2023-01-10T20:40:17Z

Description

Validates fuzziness query and returns error message on invalid fuzziness values

Issues Resolved

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sean Li <[email protected]>

server/src/main/java/org/opensearch/common/unit/Fuzziness.java

server/src/test/java/org/opensearch/common/unit/FuzzinessTests.java

Signed-off-by: Sean Li <[email protected]>

github-actions · 2023-01-11T01:47:06Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/9237/
CommitID: 8542176
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

noCharger · 2023-01-11T19:09:12Z

server/src/main/java/org/opensearch/common/unit/Fuzziness.java

@@ -189,7 +189,13 @@ public static Fuzziness parse(XContentParser parser) throws IOException {
                            return build(fuzziness);
                    }
                } catch (NumberFormatException ex) {
-                    return build(fuzziness);
+                    // Validating if the inputted Fuzziness value is a float. If not, it is an invalid string.


non blocking comment -
'Validate if the fuzziness is formatted correctly as a numeric value.'

addressed in 4409f99

noCharger

Approved with one nit comment

Signed-off-by: Sean Li <[email protected]>

github-actions · 2023-01-11T21:15:12Z

Gradle Check (Jenkins) Run Completed with:

RESULT: TIMEOUT ❌
URL: https://build.ci.opensearch.org/job/gradle-check/9309/
CommitID: 4409f99
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-01-12T05:42:39Z

Gradle Check (Jenkins) Run Completed with:

RESULT: TIMEOUT ❌
URL: https://build.ci.opensearch.org/job/gradle-check/9324/
CommitID: 4409f99
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-01-12T19:36:34Z

Gradle Check (Jenkins) Run Completed with:

RESULT: TIMEOUT ❌
URL: https://build.ci.opensearch.org/job/gradle-check/9336/
CommitID: 4409f99
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-01-12T23:14:58Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/9354/
CommitID: 4409f99
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-01-13T01:29:52Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/9360/
CommitID: 4409f99
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-01-13T03:31:18Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/9365/
CommitID: 4409f99
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Signed-off-by: Sean Li <[email protected]>

github-actions · 2023-03-08T19:02:10Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/12116/
CommitID: ff43555

Signed-off-by: Sean Li <[email protected]>

github-actions · 2023-03-08T19:40:25Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/12120/
CommitID: cae5ac1

codecov-commenter · 2023-03-08T19:44:35Z

Codecov Report

Merging #5805 (2980409) into main (8c0e5d0) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #5805      +/-   ##
============================================
- Coverage     70.77%   70.67%   -0.11%     
+ Complexity    59125    59068      -57     
============================================
  Files          4804     4804              
  Lines        283098   283101       +3     
  Branches      40813    40813              
============================================
- Hits         200372   200077     -295     
- Misses        66269    66623     +354     
+ Partials      16457    16401      -56

Impacted Files	Coverage Δ
...ain/java/org/opensearch/common/unit/Fuzziness.java	`85.00% <100.00%> (+0.46%)`	⬆️
...adonly/AddIndexBlockClusterStateUpdateRequest.java	`0.00% <0.00%> (-75.00%)`	⬇️
...readonly/TransportVerifyShardIndexBlockAction.java	`9.75% <0.00%> (-73.18%)`	⬇️
...n/admin/indices/readonly/AddIndexBlockRequest.java	`17.85% <0.00%> (-53.58%)`	⬇️
.../java/org/opensearch/node/NodeClosedException.java	`50.00% <0.00%> (-50.00%)`	⬇️
...ava/org/opensearch/action/NoSuchNodeException.java	`0.00% <0.00%> (-50.00%)`	⬇️
...a/org/opensearch/tasks/TaskCancelledException.java	`50.00% <0.00%> (-50.00%)`	⬇️
.../opensearch/client/indices/CloseIndexResponse.java	`42.50% <0.00%> (-48.75%)`	⬇️
...opensearch/persistent/PersistentTasksExecutor.java	`22.22% <0.00%> (-44.45%)`	⬇️
...adcast/BroadcastShardOperationFailedException.java	`55.55% <0.00%> (-44.45%)`	⬇️
... and 492 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

CHANGELOG.md

Signed-off-by: Sean Li <[email protected]>

github-actions · 2023-03-08T21:35:00Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/12129/
CommitID: 2980409

* Adding fuzziness validation Signed-off-by: Sean Li <[email protected]> * Updating imports Signed-off-by: Sean Li <[email protected]> * Adding fuzziness validation Signed-off-by: Sean Li <[email protected]> * Updating imports Signed-off-by: Sean Li <[email protected]> * removing comments Signed-off-by: Sean Li <[email protected]> * running spotlessApply Signed-off-by: Sean Li <[email protected]> * updating CHANGELOG.md Signed-off-by: Sean Li <[email protected]> * resolving reviews Signed-off-by: Sean Li <[email protected]> * revising comment Signed-off-by: Sean Li <[email protected]> * updating CHANGELOG.md Signed-off-by: Sean Li <[email protected]> * moving fix to 2.x in CHANGELOG.md Signed-off-by: Sean Li <[email protected]> --------- Signed-off-by: Sean Li <[email protected]> (cherry picked from commit add1871) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Adding fuzziness validation * Updating imports * Adding fuzziness validation * Updating imports * removing comments * running spotlessApply * updating CHANGELOG.md * resolving reviews * revising comment * updating CHANGELOG.md * moving fix to 2.x in CHANGELOG.md --------- (cherry picked from commit add1871) Signed-off-by: Sean Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Adding fuzziness validation Signed-off-by: Sean Li <[email protected]> * Updating imports Signed-off-by: Sean Li <[email protected]> * Adding fuzziness validation Signed-off-by: Sean Li <[email protected]> * Updating imports Signed-off-by: Sean Li <[email protected]> * removing comments Signed-off-by: Sean Li <[email protected]> * running spotlessApply Signed-off-by: Sean Li <[email protected]> * updating CHANGELOG.md Signed-off-by: Sean Li <[email protected]> * resolving reviews Signed-off-by: Sean Li <[email protected]> * revising comment Signed-off-by: Sean Li <[email protected]> * updating CHANGELOG.md Signed-off-by: Sean Li <[email protected]> * moving fix to 2.x in CHANGELOG.md Signed-off-by: Sean Li <[email protected]> --------- Signed-off-by: Sean Li <[email protected]> Signed-off-by: Mingshi Liu <[email protected]>

sejli added 8 commits January 9, 2023 02:17

Adding fuzziness validation

0da6a50

Signed-off-by: Sean Li <[email protected]>

Merge branch 'opensearch-project:main' into fuzziness_validation

35e6cf8

Updating imports

b4dd2af

Signed-off-by: Sean Li <[email protected]>

Adding fuzziness validation

bb8f47a

Signed-off-by: Sean Li <[email protected]>

Updating imports

96481e9

Signed-off-by: Sean Li <[email protected]>

removing comments

9dca8bc

Signed-off-by: Sean Li <[email protected]>

removing comments

9f5e9a8

Signed-off-by: Sean Li <[email protected]>

running spotlessApply

65d26d3

Signed-off-by: Sean Li <[email protected]>

noCharger reviewed Jan 10, 2023

View reviewed changes

server/src/main/java/org/opensearch/common/unit/Fuzziness.java Show resolved Hide resolved

server/src/main/java/org/opensearch/common/unit/Fuzziness.java Show resolved Hide resolved

server/src/test/java/org/opensearch/common/unit/FuzzinessTests.java Outdated Show resolved Hide resolved

resolving reviews

8542176

Signed-off-by: Sean Li <[email protected]>

noCharger reviewed Jan 11, 2023

View reviewed changes

noCharger approved these changes Jan 11, 2023

View reviewed changes

revising comment

4409f99

Signed-off-by: Sean Li <[email protected]>

Merging from upstream/main

ff43555

Signed-off-by: Sean Li <[email protected]>

updating CHANGELOG.md

cae5ac1

Signed-off-by: Sean Li <[email protected]>

reta reviewed Mar 8, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

moving fix to 2.x in CHANGELOG.md

2980409

Signed-off-by: Sean Li <[email protected]>

reta merged commit add1871 into opensearch-project:main Mar 8, 2023

reta added bug Something isn't working backport 2.x Backport to 2.x branch labels Mar 8, 2023

opensearch-trigger-bot bot mentioned this pull request Mar 8, 2023

[Backport 2.x] Adding query fuzziness validation #6590

Merged

This was referenced Mar 9, 2023

[BUG] fuzziness parameter isn't validated in search queries #4223

Closed

Validating fuzziness value in query #4748

Closed

sejli mentioned this pull request Apr 14, 2023

Adding more validation for fuzzy queries #7154

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding query fuzziness validation #5805

Adding query fuzziness validation #5805

sejli commented Jan 10, 2023 •

edited

Loading

github-actions bot commented Jan 11, 2023

noCharger Jan 11, 2023 •

edited

Loading

sejli Jan 11, 2023

noCharger left a comment

github-actions bot commented Jan 11, 2023

github-actions bot commented Jan 12, 2023

github-actions bot commented Jan 12, 2023

github-actions bot commented Jan 12, 2023

github-actions bot commented Jan 13, 2023

github-actions bot commented Jan 13, 2023

github-actions bot commented Mar 8, 2023

github-actions bot commented Mar 8, 2023

codecov-commenter commented Mar 8, 2023 •

edited

Loading

github-actions bot commented Mar 8, 2023

Adding query fuzziness validation #5805

Adding query fuzziness validation #5805

Conversation

sejli commented Jan 10, 2023 • edited Loading

Description

Issues Resolved

Check List

github-actions bot commented Jan 11, 2023

Gradle Check (Jenkins) Run Completed with:

noCharger Jan 11, 2023 • edited Loading

Choose a reason for hiding this comment

sejli Jan 11, 2023

Choose a reason for hiding this comment

noCharger left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 11, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jan 12, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jan 12, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jan 12, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jan 13, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jan 13, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Mar 8, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Mar 8, 2023

Gradle Check (Jenkins) Run Completed with:

codecov-commenter commented Mar 8, 2023 • edited Loading

Codecov Report

github-actions bot commented Mar 8, 2023

Gradle Check (Jenkins) Run Completed with:

sejli commented Jan 10, 2023 •

edited

Loading

noCharger Jan 11, 2023 •

edited

Loading

codecov-commenter commented Mar 8, 2023 •

edited

Loading