Renaming CPU architecture to have consistent naming #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
|
✅ DCO Check Passed a2ad608 |
|
✅ Gradle Wrapper Validation success a2ad608 |
|
start gradle check |
|
✅ Gradle Precommit success a2ad608 |
Signed-off-by: Sarat Vemulapalli <[email protected]>
|
start gradle check |
|
✅ Gradle Wrapper Validation success 6fc52ed |
|
✅ DCO Check Passed 6fc52ed |
|
✅ Gradle Precommit success 6fc52ed |
harold-wang
reviewed
Apr 26, 2021
| @@ -229,4 +230,15 @@ private void parseVersion(String version) { | |||
| hash = jdkVersionMatcher.group(5); | |||
| } | |||
|
|
|||
| private String translateJdkArchitecture(String architecture) { | |||
There was a problem hiding this comment.
Do u want to change to return architecture == "arm64"? "aarch64" : architecture; ? thx
There was a problem hiding this comment.
I like that, sure.
dblock
approved these changes
Apr 26, 2021
Signed-off-by: Sarat Vemulapalli <[email protected]>
|
start gradle check |
|
✅ Gradle Wrapper Validation success 82a3128 |
|
✅ DCO Check Passed 82a3128 |
|
✅ Gradle Precommit success 82a3128 |
harold-wang
approved these changes
Apr 26, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renaming CPU architecture to have consistent naming.
Here are the following changes:
Issues Resolved
#606
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.