-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't register destructiveDistroTest.docker twice #6930
Conversation
Signed-off-by: Daniel Widdis <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6930 +/- ##
============================================
+ Coverage 70.66% 70.72% +0.06%
- Complexity 59231 59282 +51
============================================
Files 4812 4812
Lines 283761 283759 -2
Branches 40917 40918 +1
============================================
+ Hits 200519 200695 +176
+ Misses 66784 66618 -166
+ Partials 16458 16446 -12
... and 492 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit bcbb561) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…#6930) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Valentin Mitrofanov <[email protected]>
(cherry picked from commit bcbb561) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
The
destructiveDistroTest.docker
task was already registered here:OpenSearch/buildSrc/src/main/java/org/opensearch/gradle/test/DistroTestPlugin.java
Line 245 in c85d33e
Which is called here:
OpenSearch/buildSrc/src/main/java/org/opensearch/gradle/test/DistroTestPlugin.java
Line 107 in c85d33e
Which causes duplicate registration here:
OpenSearch/buildSrc/src/main/java/org/opensearch/gradle/test/DistroTestPlugin.java
Line 124 in c85d33e
This fixes the
TODO
by adding a test whether a task is already registered in place of the exception catch/warning.Issues Resolved
Fixes #1640 (you're welcome).
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.