-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x][Search Pipelines] Add default_search_pipeline index setting (#7470) #7589
Merged
reta
merged 3 commits into
opensearch-project:2.x
from
msfroh:backport/backport-7470-to-2.x
May 17, 2023
Merged
[Backport 2.x][Search Pipelines] Add default_search_pipeline index setting (#7470) #7589
reta
merged 3 commits into
opensearch-project:2.x
from
msfroh:backport/backport-7470-to-2.x
May 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rch-project#7470) * [Search Pipelines] Add default_search_pipeline index setting Once users have defined and tested a search pipeline, they may want to apply it by default to all queries hitting a given index. Users should be able to bypass the default pipeline for the index by explicitly specifying `search_pipeline=_none` in the URL parameter of their search request. Signed-off-by: Michael Froh <[email protected]> * Rename default search pipeline setting and add getter/setter Also change version check for ad hoc pipeline to 2.8 Signed-off-by: Michael Froh <[email protected]> * Add tests for new IndexSettings methods Signed-off-by: Michael Froh <[email protected]> * Update test to reflect change to FeatureFlagSetter Signed-off-by: Michael Froh <[email protected]> --------- Signed-off-by: Michael Froh <[email protected]> (cherry picked from commit 5984735)
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Michael Froh <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #7589 +/- ##
============================================
- Coverage 70.31% 70.19% -0.13%
+ Complexity 59937 59934 -3
============================================
Files 4882 4882
Lines 288376 288393 +17
Branches 41920 41924 +4
============================================
- Hits 202777 202437 -340
- Misses 68613 68968 +355
- Partials 16986 16988 +2
|
msfroh
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng and
VachaShah
as code owners
May 17, 2023 01:31
6 tasks
reta
reviewed
May 17, 2023
rest-api-spec/src/main/resources/rest-api-spec/test/search_pipeline/10_basic.yml
Outdated
Show resolved
Hide resolved
I previously misunderstood the syntax for skipping tests by version. Thanks @reta for catching this! Signed-off-by: Michael Froh <[email protected]>
msfroh
force-pushed
the
backport/backport-7470-to-2.x
branch
from
May 17, 2023 17:48
750cdfd
to
b2e812c
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
reta
approved these changes
May 17, 2023
reta
reviewed
May 17, 2023
rest-api-spec/src/main/resources/rest-api-spec/test/search_pipeline/10_basic.yml
Show resolved
Hide resolved
msfroh
added a commit
to msfroh/OpenSearch
that referenced
this pull request
May 17, 2023
As @reta pointed out, these tests should be skipped for versions less than 2.7.0, but the skip version ranges are inclusive. So, the upper bound of the range should be 2.6.99. This brings a change made for opensearch-project#7589 onto the main branch. ssssss-off-by: Michael Froh <[email protected]>
msfroh
added a commit
to msfroh/OpenSearch
that referenced
this pull request
May 17, 2023
As @reta pointed out, these tests should be skipped for versions less than 2.7.0, but the skip version ranges are inclusive. So, the upper bound of the range should be 2.6.99. This brings a change made for opensearch-project#7589 onto the main branch. Signed-off-by: Michael Froh <[email protected]>
6 tasks
reta
pushed a commit
that referenced
this pull request
May 18, 2023
As @reta pointed out, these tests should be skipped for versions less than 2.7.0, but the skip version ranges are inclusive. So, the upper bound of the range should be 2.6.99. This brings a change made for #7589 onto the main branch. Signed-off-by: Michael Froh <[email protected]>
bharath-techie
pushed a commit
to bharath-techie/OpenSearch
that referenced
this pull request
May 23, 2023
…7618) As @reta pointed out, these tests should be skipped for versions less than 2.7.0, but the skip version ranges are inclusive. So, the upper bound of the range should be 2.6.99. This brings a change made for opensearch-project#7589 onto the main branch. Signed-off-by: Michael Froh <[email protected]> Signed-off-by: Bharathwaj G <[email protected]>
stephen-crawford
pushed a commit
to stephen-crawford/OpenSearch
that referenced
this pull request
May 31, 2023
…7618) As @reta pointed out, these tests should be skipped for versions less than 2.7.0, but the skip version ranges are inclusive. So, the upper bound of the range should be 2.6.99. This brings a change made for opensearch-project#7589 onto the main branch. Signed-off-by: Michael Froh <[email protected]>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…7618) As @reta pointed out, these tests should be skipped for versions less than 2.7.0, but the skip version ranges are inclusive. So, the upper bound of the range should be 2.6.99. This brings a change made for opensearch-project#7589 onto the main branch. Signed-off-by: Michael Froh <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once users have defined and tested a search pipeline, they may want to apply it by default to all queries hitting a given index.
Users should be able to bypass the default pipeline for the index by explicitly specifying
search_pipeline=_none
in the URL parameter of their search request.Signed-off-by: Michael Froh [email protected]
Also change version check for ad hoc pipeline to 2.8
Signed-off-by: Michael Froh [email protected]
Signed-off-by: Michael Froh [email protected]
Signed-off-by: Michael Froh [email protected]
Signed-off-by: Michael Froh [email protected]
(cherry picked from commit 5984735)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.