Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Remote Segments] Retry segment uploads to remote store on failure (#7400) #7686

Merged
merged 1 commit into from
May 23, 2023

Conversation

ashking94
Copy link
Member

@ashking94 ashking94 commented May 23, 2023

Description

This backports #7400

Related Issues

Resolves #7363

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ashking94 ashking94 changed the title [Remote Segments] Retry segment uploads to remote store on failure (#… [Backport 2.x] [Remote Segments] Retry segment uploads to remote store on failure (#7400) May 23, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString
      1 org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure

@gbbafna gbbafna merged commit 9d6c59d into opensearch-project:2.x May 23, 2023
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #7686 (cc9607c) into 2.x (80aeb76) will decrease coverage by 0.04%.
The diff coverage is 75.53%.

@@             Coverage Diff              @@
##                2.x    #7686      +/-   ##
============================================
- Coverage     70.32%   70.29%   -0.04%     
+ Complexity    60112    60107       -5     
============================================
  Files          4892     4892              
  Lines        288859   288899      +40     
  Branches      41972    41978       +6     
============================================
- Hits         203144   203082      -62     
- Misses        68771    68837      +66     
- Partials      16944    16980      +36     
Impacted Files Coverage Δ
...opensearch/snapshots/mockstore/MockRepository.java 0.00% <0.00%> (ø)
...search/index/shard/RemoteStoreRefreshListener.java 81.88% <82.92%> (+0.40%) ⬆️
...ain/java/org/opensearch/threadpool/ThreadPool.java 83.67% <100.00%> (+0.43%) ⬆️

... and 466 files with indirect coverage changes

@gbbafna gbbafna deleted the backport-7400 branch May 23, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants