-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wrapped tracer implementation #8565
Conversation
Signed-off-by: suranjay <[email protected]>
Signed-off-by: suranjay <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8565 +/- ##
============================================
- Coverage 70.94% 70.89% -0.06%
+ Complexity 57001 56970 -31
============================================
Files 4758 4759 +1
Lines 269417 269374 -43
Branches 39420 39408 -12
============================================
- Hits 191141 190962 -179
- Misses 62188 62315 +127
- Partials 16088 16097 +9
|
server/src/main/java/org/opensearch/telemetry/tracing/WrappedTracer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/telemetry/tracing/TracerFactory.java
Show resolved
Hide resolved
Signed-off-by: suranjay <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
server/src/test/java/org/opensearch/telemetry/tracing/WrappedTracerTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: suranjay <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/telemetry/tracing/TracerFactory.java
Show resolved
Hide resolved
Signed-off-by: suranjay <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8565-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7208edc1832c6be3e8548d01289a88370027e5bb
# Push it to GitHub
git push --set-upstream origin backport/backport-8565-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
@suranjay could you please create manual backport to |
Sure, on it |
* Add wrapped tracer implementation Signed-off-by: suranjay <[email protected]> * Add changelog entry Signed-off-by: suranjay <[email protected]> * Add @opensearch.internal annotation Signed-off-by: suranjay <[email protected]> * Fix test Signed-off-by: suranjay <[email protected]> * Fix changelog entry Signed-off-by: suranjay <[email protected]> --------- Signed-off-by: suranjay <[email protected]>
Backport 2.x PR: #8622 |
* Add wrapped tracer implementation * Add changelog entry * Add @opensearch.internal annotation * Fix test * Fix changelog entry --------- Signed-off-by: suranjay <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: Andriy Redko <[email protected]>
* Add wrapped tracer implementation Signed-off-by: suranjay <[email protected]> * Add changelog entry Signed-off-by: suranjay <[email protected]> * Add @opensearch.internal annotation Signed-off-by: suranjay <[email protected]> * Fix test Signed-off-by: suranjay <[email protected]> * Fix changelog entry Signed-off-by: suranjay <[email protected]> --------- Signed-off-by: suranjay <[email protected]>
* Add wrapped tracer implementation Signed-off-by: suranjay <[email protected]> * Add changelog entry Signed-off-by: suranjay <[email protected]> * Add @opensearch.internal annotation Signed-off-by: suranjay <[email protected]> * Fix test Signed-off-by: suranjay <[email protected]> * Fix changelog entry Signed-off-by: suranjay <[email protected]> --------- Signed-off-by: suranjay <[email protected]>
* Add wrapped tracer implementation Signed-off-by: suranjay <[email protected]> * Add changelog entry Signed-off-by: suranjay <[email protected]> * Add @opensearch.internal annotation Signed-off-by: suranjay <[email protected]> * Fix test Signed-off-by: suranjay <[email protected]> * Fix changelog entry Signed-off-by: suranjay <[email protected]> --------- Signed-off-by: suranjay <[email protected]>
* Add wrapped tracer implementation Signed-off-by: suranjay <[email protected]> * Add changelog entry Signed-off-by: suranjay <[email protected]> * Add @opensearch.internal annotation Signed-off-by: suranjay <[email protected]> * Fix test Signed-off-by: suranjay <[email protected]> * Fix changelog entry Signed-off-by: suranjay <[email protected]> --------- Signed-off-by: suranjay <[email protected]> Signed-off-by: sahil buddharaju <[email protected]>
* Add wrapped tracer implementation Signed-off-by: suranjay <[email protected]> * Add changelog entry Signed-off-by: suranjay <[email protected]> * Add @opensearch.internal annotation Signed-off-by: suranjay <[email protected]> * Fix test Signed-off-by: suranjay <[email protected]> * Fix changelog entry Signed-off-by: suranjay <[email protected]> --------- Signed-off-by: suranjay <[email protected]>
* Add wrapped tracer implementation Signed-off-by: suranjay <[email protected]> * Add changelog entry Signed-off-by: suranjay <[email protected]> * Add @opensearch.internal annotation Signed-off-by: suranjay <[email protected]> * Fix test Signed-off-by: suranjay <[email protected]> * Fix changelog entry Signed-off-by: suranjay <[email protected]> --------- Signed-off-by: suranjay <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
This change adds a wrapper tracer implementation.
TracerFactor now returns this wrapped tracer if the telemetry plugin is installed. The wrapped tracer checks the telemetry settings before returning the right tracer object
Related Issues
Resolves #[8561]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.