Resolve core Xcontent and CircuitBreaker refactor #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
lezzago
requested review from
AWSHurneyt,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn and
rishabhmaurya
as code owners
Signed-off-by: Ashish Agrawal <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1062 +/- ##
============================================
+ Coverage 72.13% 72.55% +0.42%
+ Complexity 113 105 -8
============================================
Files 160 160
Lines 10301 10324 +23
Branches 1571 1518 -53
============================================
+ Hits 7431 7491 +60
+ Misses 1977 1974 -3
+ Partials 893 859 -34
|
eirsep
reviewed
Aug 1, 2023
| @@ -115,6 +115,7 @@ dependencies { | |||
| api project(":alerting-core") | |||
| implementation "com.github.seancfoley:ipaddress:5.3.3" | |||
|
|
|||
| testImplementation "org.antlr:antlr4-runtime:${versions.antlr4}" | |||
There was a problem hiding this comment.
This causes the integration tests to fail since its missing this dependency. This is because it is used by the Painless scripts and its caused by the BucketSelectorExtAggregator. I tried having this change in common-utils, but it wouldn't help.
eirsep
approved these changes
Aug 1, 2023
AWSHurneyt
approved these changes
Aug 1, 2023
lezzago
added a commit
to lezzago/alerting-opensearch
that referenced
this pull request
Aug 21, 2023
…#1062) * Resolve core Xcontent refactor Signed-off-by: Ashish Agrawal <[email protected]> * Resolve core CircuitBreaker refactor Signed-off-by: Ashish Agrawal <[email protected]> * Resolve integ test issues with adding test dependency Signed-off-by: Ashish Agrawal <[email protected]> --------- Signed-off-by: Ashish Agrawal <[email protected]>
1 task
lezzago
added a commit
that referenced
this pull request
Aug 23, 2023
* Update imports for files refactored in core PR #8157 (#1025) Signed-off-by: Ashish Agrawal <[email protected]> * Resolve core Xcontent and CircuitBreaker refactor (#1062) * Resolve core Xcontent refactor Signed-off-by: Ashish Agrawal <[email protected]> * Resolve core CircuitBreaker refactor Signed-off-by: Ashish Agrawal <[email protected]> * Resolve integ test issues with adding test dependency Signed-off-by: Ashish Agrawal <[email protected]> --------- Signed-off-by: Ashish Agrawal <[email protected]> * fix breaking change from core library refactor (#1090) Signed-off-by: Surya Sashank Nistala <[email protected]> * Resolve additional compile issues Signed-off-by: Ashish Agrawal <[email protected]> * fix bwc issues Signed-off-by: Ashish Agrawal <[email protected]> * Update BWC version to deal with ktlint issues Signed-off-by: Ashish Agrawal <[email protected]> * Update BWC version Signed-off-by: Ashish Agrawal <[email protected]> * Disable BWC for non-bwc CIs Signed-off-by: Ashish Agrawal <[email protected]> * Fix integ tests and update CI flows Signed-off-by: Ashish Agrawal <[email protected]> --------- Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: Surya Sashank Nistala <[email protected]> Co-authored-by: Surya Sashank Nistala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Resolve core Xcontent refactor from opensearch-project/OpenSearch#8826
Resolve core CircuitBreaker refactor from opensearch-project/OpenSearch#9006
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.