Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the Master nomenclature in 2.0 #415

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Deprecate the Master nomenclature in 2.0 #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion alerting/src/main/kotlin/org/opensearch/alerting/alerts/AlertIndices.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ import java.time.Instant
* date based index. The frequency of rolling over indices is controlled by the `opendistro.alerting.alert_rollover_period` setting.
*
* These indexes are created when first used and are then rolled over every `alert_rollover_period`. The rollover is
* initiated on the master node to ensure only a single node tries to roll it over. Once we have a curator functionality
* initiated on the cluster manager node to ensure only a single node tries to roll it over. Once we have a curator functionality
* in Scheduled Jobs we can migrate to using that to rollover the index.
*/
// TODO: reafactor to make a generic version of this class for finding and alerts
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/kotlin/org/opensearch/alerting/core/JobSweeper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ class JobSweeper(
* the cluster, a replica is added, removed or promoted to primary).
*
* This callback won't be invoked concurrently since cluster state changes are applied serially to the node
* in the order they occur on the master. However we can't block this callback for the duration of a full sweep so
* in the order they occur on the cluster manager. However we can't block this callback for the duration of a full sweep so
* we perform the sweep in the background in a single threaded executor [fullSweepExecutor].
*/
override fun clusterChanged(event: ClusterChangedEvent) {
Expand Down