Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump anomaly-detection version to 1.2 #286

Merged
merged 2 commits into from
Nov 5, 2021
Merged

Bump anomaly-detection version to 1.2 #286

merged 2 commits into from
Nov 5, 2021

Conversation

jackiehanyang
Copy link
Collaborator

@jackiehanyang jackiehanyang commented Nov 5, 2021

Signed-off-by: Jackie Han [email protected]

Description

  • Bump version to 1.2.
  • Grab dependencies SNAPSHOTs from maven instead of building them locally.
  • Remove Checkstyle plugin as OpenSearch Core package removed its usage.
  • Force Jackson version to be 2.11.4 to avoid a version conflict issue.
  • Force Mockito-core version to 2.11.4 to avoid a version conflict issue.
  • Update some integration tests to resolve failed integration tests issue.

Issues Resolved

#229

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

Codecov Report

Merging #286 (9cd2802) into main (44baa81) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #286      +/-   ##
============================================
- Coverage     76.40%   76.36%   -0.05%     
+ Complexity     3900     3897       -3     
============================================
  Files           294      294              
  Lines         16743    16743              
  Branches       1736     1736              
============================================
- Hits          12793    12785       -8     
- Misses         3164     3175      +11     
+ Partials        786      783       -3     
Flag Coverage Δ
plugin 76.36% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/opensearch/ad/model/DetectorValidationIssue.java 47.36% <0.00%> (-7.02%) ⬇️
...java/org/opensearch/ad/task/ADBatchTaskRunner.java 81.65% <0.00%> (-3.98%) ⬇️
...ansport/handler/AnomalyResultBulkIndexHandler.java 67.74% <0.00%> (-3.23%) ⬇️
...ava/org/opensearch/ad/task/ADHCBatchTaskCache.java 90.12% <0.00%> (-1.24%) ⬇️
...ain/java/org/opensearch/ad/task/ADTaskManager.java 75.81% <0.00%> (-0.39%) ⬇️
...ava/org/opensearch/ad/task/ADTaskCacheManager.java 89.31% <0.00%> (+0.95%) ⬆️
...in/java/org/opensearch/ad/model/ADTaskProfile.java 50.63% <0.00%> (+2.10%) ⬆️
.../org/opensearch/ad/transport/RCFResultRequest.java 95.00% <0.00%> (+2.50%) ⬆️
...va/org/opensearch/ad/transport/ProfileRequest.java 100.00% <0.00%> (+4.00%) ⬆️
...earch/ad/transport/GetAnomalyDetectorResponse.java 91.91% <0.00%> (+5.05%) ⬆️
... and 3 more

@jackiehanyang jackiehanyang merged commit ca196b8 into opensearch-project:main Nov 5, 2021
@sean-zheng-amazon sean-zheng-amazon linked an issue Nov 9, 2021 that may be closed by this pull request
@jackiehanyang jackiehanyang added the version upgrade Upgrading OpenSearch compatibility label Nov 9, 2021
@ylwu-amzn ylwu-amzn mentioned this pull request Jan 14, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version upgrade Upgrading OpenSearch compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use SNAPSHOT artifacts from maven for dependencies
3 participants