Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added groupId to pluginzip publication #568

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

sricharanvuppu
Copy link
Member

@sricharanvuppu sricharanvuppu commented Sep 27, 2022

Signed-off-by: sricharanvuppu [email protected]

Description

Added groupId as org.opensearch.plugin in pluginZip publication

Issues Resolved

#534

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sricharanvuppu sricharanvuppu requested a review from a team September 27, 2022 06:51
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

Merging #568 (e54bd0a) into main (e1dc511) will decrease coverage by 0.32%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #568      +/-   ##
============================================
- Coverage     75.08%   74.75%   -0.33%     
+ Complexity     1007     1003       -4     
============================================
  Files           141      141              
  Lines          4595     4595              
  Branches        506      506              
============================================
- Hits           3450     3435      -15     
- Misses          834      845      +11     
- Partials        311      315       +4     
Impacted Files Coverage Δ
...arch/replication/metadata/UpdateMetadataRequest.kt 77.27% <0.00%> (-22.73%) ⬇️
...cation/action/changes/TransportGetChangesAction.kt 84.12% <0.00%> (-6.35%) ⬇️
...action/stop/TransportStopIndexReplicationAction.kt 60.75% <0.00%> (-5.07%) ⬇️
...earch/replication/metadata/UpdateIndexBlockTask.kt 74.19% <0.00%> (-3.23%) ⬇️
...ation/task/shard/ShardReplicationChangesTracker.kt 60.60% <0.00%> (-3.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ankitkala
Copy link
Member

LGTM. Let's wait for confirmation from @prudhvigodithi incase anything else is required.

@prudhvigodithi
Copy link
Contributor

Looks good, but should be back-ported to 2.x only during 2.4 release else the build would break.
related PR opensearch-project/OpenSearch#4360
CC @lukas-vlcek

@sricharanvuppu
Copy link
Member Author

@prudhvigodithi Can we merge this to main

@prudhvigodithi
Copy link
Contributor

Hey @sricharanvuppu, yes we can merge this PR, but lets not backport it to 2.x I would suggest to just wait until the following PR is backported to 2.x from core, else the distribution build would fail compiling cross-cluster-replication for 2.4 version. @bbarani @lukas-vlcek @dblock
opensearch-project/OpenSearch#4360 (comment)
Thank you

@prudhvigodithi prudhvigodithi merged commit 33571ca into main Oct 12, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 12, 2022
Signed-off-by: sricharanvuppu <[email protected]>

Signed-off-by: sricharanvuppu <[email protected]>
(cherry picked from commit 33571ca)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants