-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added groupId to pluginzip publication #568
Conversation
Signed-off-by: sricharanvuppu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #568 +/- ##
============================================
- Coverage 75.08% 74.75% -0.33%
+ Complexity 1007 1003 -4
============================================
Files 141 141
Lines 4595 4595
Branches 506 506
============================================
- Hits 3450 3435 -15
- Misses 834 845 +11
- Partials 311 315 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
LGTM. Let's wait for confirmation from @prudhvigodithi incase anything else is required. |
Looks good, but should be back-ported to 2.x only during 2.4 release else the build would break. |
@prudhvigodithi Can we merge this to main |
Hey @sricharanvuppu, yes we can merge this PR, but lets not backport it to 2.x I would suggest to just wait until the following PR is backported to 2.x from core, else the distribution build would fail compiling cross-cluster-replication for 2.4 version. @bbarani @lukas-vlcek @dblock |
Signed-off-by: sricharanvuppu <[email protected]> Signed-off-by: sricharanvuppu <[email protected]> (cherry picked from commit 33571ca)
Signed-off-by: sricharanvuppu [email protected]
Description
Added
groupId
asorg.opensearch.plugin
inpluginZip
publicationIssues Resolved
#534
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.