[Backport 2.x] Reverting notebooks changes, add docs/validation to datasources, explorer minor fixes #1102
+913
−201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…orer minor fixes (#1101) * Add documentation linking and validation for query permissions Signed-off-by: Derek Ho <[email protected]> * Update test with link Signed-off-by: Derek Ho <[email protected]> * Add form validation for name field Signed-off-by: Derek Ho <[email protected]> * reverting notebook changes from #974 & #985 Signed-off-by: Shenoy Pratik <[email protected]> * Remove console log Signed-off-by: Derek Ho <[email protected]> * surrounding events functionally working Signed-off-by: Paul Sebastian <[email protected]> * small surrounding flyout ui changes Signed-off-by: Paul Sebastian <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> (cherry picked from commit 4a8b500) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
kavithacm
approved these changes
Oct 9, 2023
vamsi-amazon
approved these changes
Oct 9, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #1102 +/- ##
==========================================
+ Coverage 44.09% 44.23% +0.13%
==========================================
Files 325 327 +2
Lines 19378 19478 +100
Branches 4617 4643 +26
==========================================
+ Hits 8545 8616 +71
- Misses 10788 10817 +29
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. |
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…orer minor fixes (opensearch-project#1101) (opensearch-project#1102) * Add documentation linking and validation for query permissions * Update test with link * Add form validation for name field * reverting notebook changes from opensearch-project#974 & opensearch-project#985 * Remove console log * surrounding events functionally working * small surrounding flyout ui changes --------- (cherry picked from commit 4a8b500) Signed-off-by: Derek Ho <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Shenoy Pratik <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> (cherry picked from commit 2d4afc3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 4a8b500 from #1101.