Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @cypress/request resolution to fix CVE-2023-28155 #245

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Sep 7, 2023

Description

Upgrade requests to 3.0

Issues Resolved

fix CVE-2023-28155

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #245 (f8fc21a) into main (5101793) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files           5        5           
  Lines         152      152           
  Branches       45       45           
=======================================
  Hits          144      144           
  Misses          8        8           

📢 Have feedback on the report? Share it here.

@ps48 ps48 merged commit b9bb0ae into opensearch-project:main Sep 7, 2023
10 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-visualizations/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-visualizations/backport-2.x
# Create a new branch
git switch --create backport/backport-245-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b9bb0ae96228f9925152018247aa9838ffbed554
# Push it to GitHub
git push --set-upstream origin backport/backport-245-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-visualizations/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-245-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-visualizations/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/dashboards-visualizations/backport-1.3
# Create a new branch
git switch --create backport/backport-245-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b9bb0ae96228f9925152018247aa9838ffbed554
# Push it to GitHub
git push --set-upstream origin backport/backport-245-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-visualizations/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-245-to-1.3.

@joshuali925
Copy link
Member

1.3 backported in #257, removing failed backport label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants