Remove the duplicate key/value when ingesting log from opentelemetry-dotnet #4394
Conversation
hoangthanh28
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed,
dlvenable and
oeyh
as code owners
There was a problem hiding this comment.
Change looks good to me. I wonder, whether we want tests for that. But this is just Java Streams API. @hoangthanh28, check your commit messages for correct DCO: "signed-off-by: ..."
|
@hoangthanh28 , Thank you for this contribution! I agree with @KarstenSchnitter that we should have a unit test. You can write a test which sends in multiple values and make sure you get the last one. |
hoangthanh28
force-pushed
the
features/thanh/otel_collector_key_duplication
branch
from
4b16bc6
to
a583b93
Compare
Signed-off-by: Thanh Tran <[email protected]>
Signed-off-by: Thanh Tran <[email protected]>
hoangthanh28
force-pushed
the
features/thanh/otel_collector_key_duplication
branch
from
a583b93
to
24ae806
Compare
| .addAllAttributes(Arrays.asList(duplicateAttribute1, duplicateAttribute2)).build(); | ||
|
|
||
| Map<String, Object> map = OTelProtoCodec.convertKeysOfDataPointAttributes(actual); | ||
| assertThat(map.size(), is(equalTo(1))); |
There was a problem hiding this comment.
I understand, that it is enough to test for non-duplication. However, this is unspecified behaviour, when the key values are different. It is not clear, which value will be chosen. Even if this is undocumented behaviour, I think the unit test should force a specific selection. This is how I understand @dlvenable comment: #4394 (comment)
|
Merge from original repo |
Description
This PR is intended to resolve the duplicate key exception while ingesting the otel-dotnet log.
Issues Resolved
Resolves #3868
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.