Adding a new API to get the current transformed pipelines as a JSON #4980
Conversation
Signed-off-by: Souvik Bose <[email protected]>
sb2k16
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
| @@ -30,6 +30,7 @@ public class DataPrepperServer { | |||
| private static final Logger LOG = LoggerFactory.getLogger(DataPrepperServer.class); | |||
| private final HttpServerProvider serverProvider; | |||
| private final ListPipelinesHandler listPipelinesHandler; | |||
| private final GetTransformedPipelinesBodyHandler getTransformedPipelinesBodyHandler; | |||
There was a problem hiding this comment.
Should this be getTransformedPipelinesConfigHander?
| @@ -67,6 +70,7 @@ private HttpServer createServer() { | |||
|
|
|||
| createContext(server, listPipelinesHandler, authenticator, "/list"); | |||
| createContext(server, shutdownHandler, authenticator, "/shutdown"); | |||
| createContext(server, getTransformedPipelinesBodyHandler, authenticator, "/getPipelineBody"); | |||
There was a problem hiding this comment.
Same as above. Should this be /getPipelineTransformedConfig. Who knows we may need /getPipelineConfig in future to get the config before transformation.
There was a problem hiding this comment.
How about /pipelines/transformed?
There was a problem hiding this comment.
Or maybe this should just be pipelines? I think it makes sense to send the transformed pipelines by default.
| @@ -67,6 +70,7 @@ private HttpServer createServer() { | |||
|
|
|||
| createContext(server, listPipelinesHandler, authenticator, "/list"); | |||
| createContext(server, shutdownHandler, authenticator, "/shutdown"); | |||
| createContext(server, getTransformedPipelinesBodyHandler, authenticator, "/getPipelineBody"); | |||
There was a problem hiding this comment.
How about /pipelines/transformed?
| @@ -67,6 +70,7 @@ private HttpServer createServer() { | |||
|
|
|||
| createContext(server, listPipelinesHandler, authenticator, "/list"); | |||
| createContext(server, shutdownHandler, authenticator, "/shutdown"); | |||
| createContext(server, getTransformedPipelinesBodyHandler, authenticator, "/getPipelineBody"); | |||
There was a problem hiding this comment.
Or maybe this should just be pipelines? I think it makes sense to send the transformed pipelines by default.
| @Override | ||
| public void handle(final HttpExchange exchange) throws IOException { | ||
| String requestMethod = exchange.getRequestMethod(); | ||
| if (!requestMethod.equals(HttpMethod.GET) && !requestMethod.equals(HttpMethod.POST)) { |
There was a problem hiding this comment.
Let's only support GET on this one. It is only getting the pipelines after all.
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| public class GetTransformedPipelinesBodyHandler implements HttpHandler { |
There was a problem hiding this comment.
I don't know if we need Transformed here. The pipeline transformation happens before any pipelines are created. So the transformed pipelines are the real pipelines.
Signed-off-by: Souvik Bose <[email protected]>
…pensearch-project#4980) * Adding a new API to get the current transformed pipelines as a JSON Signed-off-by: Souvik Bose <[email protected]> * Rename the api and address comments Signed-off-by: Souvik Bose <[email protected]> --------- Signed-off-by: Souvik Bose <[email protected]> Co-authored-by: Souvik Bose <[email protected]>
Description
This PR Is to add a new API to get the body of the transformed pipelines running in the current data prepper instance as an entire JSON string. The API supports both GET and POST methods.
The main purpose is to have a mechanism to get the transformed body of the entire set of pipelines running in the current data prepper instance which should enable faster debugging and troubleshooting purpose.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.