Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation for using search pipeline for multiple indices #7053

Merged
merged 7 commits into from
May 8, 2024

Conversation

owaiskazi19
Copy link
Member

@owaiskazi19 owaiskazi19 commented Apr 29, 2024

Description

Documentation for opensearch-project/OpenSearch#13276

Issues Resolved

Resolves #7035

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@owaiskazi19
Copy link
Member Author

@msfroh @dbwiddis can you take a look? Thanks

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with Minal's edit.

_search-plugins/search-pipelines/using-search-pipeline.md Outdated Show resolved Hide resolved
@Naarcha-AWS Naarcha-AWS added backport 2.13 PR: Backport label for 2.13 4 - Doc review PR: Doc review in progress labels Apr 30, 2024
@hdhalter hdhalter added v2.14.0 and removed backport 2.13 PR: Backport label for 2.13 labels May 6, 2024
Copy link
Collaborator

@vagimeli vagimeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc review complete with edits for clarity and style. Moving to editorial review

@vagimeli vagimeli added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels May 7, 2024
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@owaiskazi19 @vagimeli Just one comment. Thanks!

@@ -130,6 +130,53 @@ The response contains only the public document, indicating that the pipeline was
```
</details>

You can search across multiple indexes that share the same default pipeline. For example, `alias1` has two indexes, `my_index1` and `my_index2`, both of which have the default pipeline `my_pipeline` attached to them.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this end with a colon?

@vagimeli vagimeli merged commit d0301e3 into opensearch-project:main May 8, 2024
5 checks passed
@vagimeli vagimeli removed the 5 - Editorial review PR: Editorial review in progress label May 8, 2024
@hdhalter hdhalter added release-notes PR: Include this PR in the automated release notes 3 - Done Issue is done/complete labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete release-notes PR: Include this PR in the automated release notes v2.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Update documentation for Using Search Pipeline
7 participants